From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Sam Protsenko <semen.protsenko@linaro.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Ryu Euiyoul <ryu.real@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] pinctrl: samsung: Fix pinctrl bank pin count
Date: Mon, 2 Aug 2021 15:23:42 +0200 [thread overview]
Message-ID: <162791061524.24470.4507251211900093020.b4-ty@canonical.com> (raw)
In-Reply-To: <20210730192905.7173-1-semen.protsenko@linaro.org>
On Fri, 30 Jul 2021 22:29:05 +0300, Sam Protsenko wrote:
> Commit 1abd18d1a51a ("pinctrl: samsung: Register pinctrl before GPIO")
> changes the order of GPIO and pinctrl registration: now pinctrl is
> registered before GPIO. That means gpio_chip->ngpio is not set when
> samsung_pinctrl_register() called, and one cannot rely on that value
> anymore. Use `pin_bank->nr_pins' instead of `pin_bank->gpio_chip.ngpio'
> to fix mentioned inconsistency.
Applied, thanks!
[1/1] pinctrl: samsung: Fix pinctrl bank pin count
commit: 70115558ab02fe8d28a6634350b3491a542aaa02
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
prev parent reply other threads:[~2021-08-02 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 19:29 [PATCH] pinctrl: samsung: Fix pinctrl bank pin count Sam Protsenko
2021-08-02 13:23 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162791061524.24470.4507251211900093020.b4-ty@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ryu.real@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).