From: "Heiko Stübner" <heiko@sntech.de>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
mturquette@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
t.figa@samsung.com
Subject: Re: [PATCH 2/4] clk: samsung: remove np check in clock init
Date: Tue, 12 Mar 2013 10:17:49 +0100 [thread overview]
Message-ID: <201303121017.49655.heiko@sntech.de> (raw)
In-Reply-To: <201303121002.56535.heiko@sntech.de>
Am Dienstag, 12. März 2013, 10:02:55 schrieb Heiko Stübner:
> Am Dienstag, 12. März 2013, 09:53:00 schrieb Thomas Abraham:
> > On 12 March 2013 05:14, Heiko Stübner <heiko@sntech.de> wrote:
> > > This let to the suspend init never being reached on non-DT platforms.
> > >
> > > Signed-off-by: Heiko Stueber <heiko@sntech.de>
> > > ---
> > >
> > > drivers/clk/samsung/clk.c | 2 --
> > > 1 files changed, 0 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c
> > > index d36cdd5..1a5de69 100644
> > > --- a/drivers/clk/samsung/clk.c
> > > +++ b/drivers/clk/samsung/clk.c
> > > @@ -57,8 +57,6 @@ void __init samsung_clk_init(struct device_node *np,
> > > void __iomem *base,
> > >
> > > unsigned long nr_rdump)
> > >
> > > {
> > >
> > > reg_base = base;
> > >
> > > - if (!np)
> > > - return;
> >
> > Hi Heiko,
> >
> > Sorry, I did not understand the need for this. Could you please add
> > few more details on this change.
>
> Hi Thomas,
>
> On non-dt platforms the init would stop here, therefore never reaching the
> code that inits the syscore ops below to save the register values on
> suspend and restores them on resume.
>
> I might be overlooking something, but I think we want to save/restore the
> register values on both dt and non-dt platforms.
ok, I did overlook something :-)
The register saving seems to be done separately on non-dt platforms (mach-
exynos/pm.c for example). So I probably need to redo patch 2 and 3.
Heiko
> > > #ifdef CONFIG_OF
> > >
> > > clk_table = kzalloc(sizeof(struct clk *) * nr_clks,
> > > GFP_KERNEL);
> > >
> > > --
> > > 1.7.2.3
next prev parent reply other threads:[~2013-03-12 9:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 23:42 [PATCH 0/4] clk: samsung: small fixes and enhancements Heiko Stübner
2013-03-11 23:43 ` [PATCH 1/4] clk: samsung: register clk_div_tables for divider clocks Heiko Stübner
2013-03-12 8:50 ` Thomas Abraham
2013-03-11 23:44 ` [PATCH 2/4] clk: samsung: remove np check in clock init Heiko Stübner
2013-03-12 8:53 ` Thomas Abraham
2013-03-12 9:02 ` Heiko Stübner
2013-03-12 9:17 ` Heiko Stübner [this message]
2013-03-12 9:36 ` Thomas Abraham
2013-03-12 9:54 ` Heiko Stübner
2013-03-11 23:44 ` [PATCH 3/4] clk: samsung: always allocate the clk_table Heiko Stübner
2013-03-12 9:54 ` Thomas Abraham
2013-03-12 10:50 ` Heiko Stübner
2013-03-12 11:26 ` Thomas Abraham
2013-03-12 11:23 ` Sylwester Nawrocki
2013-03-12 11:46 ` Thomas Abraham
2013-03-12 13:48 ` Sylwester Nawrocki
2013-03-12 14:24 ` Thomas Abraham
2013-03-13 3:00 ` Alim Akhtar
2013-03-13 3:35 ` Sachin Kamat
2013-03-13 5:13 ` Kyungmin Park
2013-03-11 23:45 ` [PATCH 4/4] clk: samsung: add infrastructure to add separate aliases Heiko Stübner
2013-03-12 9:57 ` Thomas Abraham
2013-03-12 10:04 ` Heiko Stübner
2013-03-12 10:48 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303121017.49655.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sylvester.nawrocki@gmail.com \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).