From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 037D1C433FE for ; Fri, 10 Sep 2021 10:12:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB56061153 for ; Fri, 10 Sep 2021 10:12:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232209AbhIJKNo (ORCPT ); Fri, 10 Sep 2021 06:13:44 -0400 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:42015 "EHLO wnew4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232094AbhIJKNn (ORCPT ); Fri, 10 Sep 2021 06:13:43 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 478942B00939; Fri, 10 Sep 2021 06:12:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 10 Sep 2021 06:12:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:content-type:mime-version :content-transfer-encoding; s=fm3; bh=/wYkDAweBEVV6XEJJiBjkmdd+f sR/vIPk4SFnyRJIEw=; b=Z61vRn/pjHuIVK0U8iQQc6o02wWjGgSy5Mq7VhkrtG 9KszoGSplOrJbMAi690ob1Z1Rbd6CXaR0bSdSKloPkNc+4MadfECmZcsS+Iyqg9p wNh+rC18qzcHP5JJUUrGVSUzBgTA/SgkNH5ZsIkacsKcfGDwkjzYgyoV/8tFkqYc M9igqVSgwO5qcewjWPkP11YhCGrq81Qao6UmtRA988I+FV2FJkQPbDonbvBulIfF b9LRs4TR/1m8RlY9zO6rhexNIqQanbrnqQ1a2/QOo8SHhVlfM/Ob9Gu/FWnkjmX/ MDod8kaA/25VHLY3v4qc94NOZO5nSZ8fXOfFa3rMpSmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=/wYkDA weBEVV6XEJJiBjkmdd+fsR/vIPk4SFnyRJIEw=; b=Tp3/xf5wSTYdhQexa5+jVb /Xr2459iQLqKuECB5obggKx1lCx+O/eqxynoA7E5Jjt9EQf4op6D3dPnOTs31XVY Yo/g7EK8pytjoO5L5bzIEu+dNFNUCIFwBmbKYGDFibf5n3mNDeL44Cg90xk3d1VN +k08B81vz2EBeUAOZ9SWmb1NXeEZgvmfahmSCQiYzThjnNDtCXCCnJxJYXdqc8qw nqKfTYEi0KIA5VHD1ODoNYop3lWLl6ASkwLXZbIXmiyUGgBBzkTvTCDsE5tBsOp+ kPYm2rVnR3nYOudb6qmTPmLegTjDSZEAlbOEr4p1qrTE0ZM7NxmT6f/FVWvUPgYg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeguddgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffotggggfesthhqredtredtjeenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeetieekgfffkeegkeeltdehudetteejgfekueevhffhteegudfgkedtueegfffg feenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Sep 2021 06:12:19 -0400 (EDT) From: Maxime Ripard To: Andrzej Hajda , Sam Ravnborg , Daniel Vetter , David Airlie , Jonas Karlman , Laurent Pinchart , Thierry Reding , Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard , Neil Armstrong , Robert Foss , Jernej Skrabec Cc: Sean Paul , freedreno@lists.freedesktop.org, Kyungmin Park , linux-kernel@vger.kernel.org, Xinliang Liu , Seung-Woo Kim , Tian Tao , Inki Dae , linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Clark , dri-devel@lists.freedesktop.org, John Stultz , Chen Feng , Xinwei Kong , Joonyoung Shim Subject: [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent Date: Fri, 10 Sep 2021 12:11:54 +0200 Message-Id: <20210910101218.1632297-1-maxime@cerno.tech> X-Mailer: git-send-email 2.31.1 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Hi,=0D =0D We've encountered an issue with the RaspberryPi DSI panel that prevented th= e=0D whole display driver from probing.=0D =0D The issue is described in detail in the commit 7213246a803f ("drm/vc4: dsi:= =0D Only register our component once a DSI device is attached"), but the basic = idea=0D is that since the panel is probed through i2c, there's no synchronization=0D between its probe and the registration of the MIPI-DSI host it's attached t= o.=0D =0D We initially moved the component framework registration to the MIPI-DSI Hos= t=0D attach hook to make sure we register our component only when we have a DSI= =0D device attached to our MIPI-DSI host, and then use lookup our DSI device in= our=0D bind hook.=0D =0D However, all the DSI bridges controlled through i2c are only registering th= eir=0D associated DSI device in their bridge attach hook, meaning with our change= =0D above, we never got that far, and therefore ended up in the same situation = than=0D the one we were trying to fix for panels.=0D =0D The best practice to avoid those issues is to register its functions only a= fter=0D all its dependencies are live. We also shouldn't wait any longer than we sh= ould=0D to play nice with the other components that are waiting for us, so in our c= ase=0D that would mean moving the DSI device registration to the bridge probe.=0D =0D I also had a look at all the DSI hosts, and it seems that exynos, kirin and= msm=0D would be affected by this and wouldn't probe anymore after those changes.=0D Exynos and kirin seems to be simple enough for a mechanical change (that st= ill=0D requires to be tested), but the changes in msm seemed to be far more import= ant=0D and I wasn't confortable doing them.=0D =0D Let me know what you think,=0D Maxime=0D =0D ---=0D =0D Changes from v3:=0D - Converted exynos and kirin=0D - Converted all the affected bridge drivers=0D - Reworded the documentation a bit=0D =0D Changes from v2:=0D - Changed the approach as suggested by Andrzej, and aligned the bridge on= the=0D panel this time.=0D - Fixed some typos=0D =0D Changes from v1:=0D - Change the name of drm_of_get_next function to drm_of_get_bridge=0D - Mention the revert of 87154ff86bf6 and squash the two patches that were= =0D reverting that commit=0D - Add some documentation=0D - Make drm_panel_attach and _detach succeed when no callback is there=0D =0D Maxime Ripard (24):=0D drm/bridge: Add documentation sections=0D drm/bridge: Document the probe issue with MIPI-DSI bridges=0D drm/mipi-dsi: Create devm device registration=0D drm/mipi-dsi: Create devm device attachment=0D drm/bridge: adv7533: Switch to devm MIPI-DSI helpers=0D drm/bridge: adv7511: Register and attach our DSI device at probe=0D drm/bridge: anx7625: Switch to devm MIPI-DSI helpers=0D drm/bridge: anx7625: Register and attach our DSI device at probe=0D drm/bridge: lt8912b: Switch to devm MIPI-DSI helpers=0D drm/bridge: lt8912b: Register and attach our DSI device at probe=0D drm/bridge: lt9611: Switch to devm MIPI-DSI helpers=0D drm/bridge: lt9611: Register and attach our DSI device at probe=0D drm/bridge: lt9611uxc: Switch to devm MIPI-DSI helpers=0D drm/bridge: lt9611uxc: Register and attach our DSI device at probe=0D drm/bridge: ps8640: Switch to devm MIPI-DSI helpers=0D drm/bridge: ps8640: Register and attach our DSI device at probe=0D drm/bridge: sn65dsi83: Switch to devm MIPI-DSI helpers=0D drm/bridge: sn65dsi83: Register and attach our DSI device at probe=0D drm/bridge: sn65dsi86: Switch to devm MIPI-DSI helpers=0D drm/bridge: sn65dsi86: Register and attach our DSI device at probe=0D drm/bridge: tc358775: Switch to devm MIPI-DSI helpers=0D drm/bridge: tc358775: Register and attach our DSI device at probe=0D drm/kirin: dsi: Adjust probe order=0D drm/exynos: dsi: Adjust probe order=0D =0D Documentation/gpu/drm-kms-helpers.rst | 12 +++=0D drivers/gpu/drm/bridge/adv7511/adv7511.h | 1 -=0D drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 15 ++-=0D drivers/gpu/drm/bridge/adv7511/adv7533.c | 20 +---=0D drivers/gpu/drm/bridge/analogix/anx7625.c | 40 ++++----=0D drivers/gpu/drm/bridge/lontium-lt8912b.c | 31 ++----=0D drivers/gpu/drm/bridge/lontium-lt9611.c | 62 +++++-------=0D drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 65 +++++-------=0D drivers/gpu/drm/bridge/parade-ps8640.c | 101 ++++++++++---------=0D drivers/gpu/drm/bridge/tc358775.c | 50 +++++----=0D drivers/gpu/drm/bridge/ti-sn65dsi83.c | 86 ++++++++--------=0D drivers/gpu/drm/bridge/ti-sn65dsi86.c | 94 ++++++++---------=0D drivers/gpu/drm/drm_bridge.c | 69 ++++++++++++-=0D drivers/gpu/drm/drm_mipi_dsi.c | 81 +++++++++++++++=0D drivers/gpu/drm/exynos/exynos_drm_dsi.c | 19 ++--=0D drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 27 +++--=0D include/drm/drm_mipi_dsi.h | 4 +=0D 17 files changed, 460 insertions(+), 317 deletions(-)=0D =0D -- =0D 2.31.1=0D =0D