From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Denis GNUtoo Carikli <GNUtoo@cyberdimension.org>,
Simon Shields <simon@lineageos.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>
Subject: Re: [PATCH 05/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it in Trats
Date: Mon, 31 Aug 2020 11:49:25 +0200 [thread overview]
Message-ID: <22b599d2-57a4-54d1-c68f-015e201a7415@samsung.com> (raw)
In-Reply-To: <20200830135200.24304-5-krzk@kernel.org>
On 30.08.2020 15:51, Krzysztof Kozlowski wrote:
> The S3C RTC requires 32768 Hz clock as input which is provided by PMIC
> (Maxim MAX8997). However there is no clock provided for the PMIC and
> the driver registers the clock as regulator. This is an old driver
> which will not be updated so add a workaround:
> 1. Enable the "clock" regulator in PMIC,
> 2. Add a fixed-clock to fill missing clock phandle reference in S3C RTC.
>
> This allows to enable the S3C RTC and fixes dtbs_check warnings:
>
> arch/arm/boot/dts/exynos4210-trats.dt.yaml: rtc@10070000: clocks: [[5, 346]] is too short
> arch/arm/boot/dts/exynos4210-trats.dt.yaml: rtc@10070000: clock-names: ['rtc'] is too short
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Confirmed, this workaround enables s3c-rtc driver operation on this board.
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm/boot/dts/exynos4210-trats.dts | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
> index 5cc96f04a4fa..634f009b622e 100644
> --- a/arch/arm/boot/dts/exynos4210-trats.dts
> +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> @@ -132,6 +132,13 @@
> compatible = "samsung,clock-xusbxti";
> clock-frequency = <24000000>;
> };
> +
> + pmic_ap_clk: pmic-ap-clk {
> + /* Workaround for missing clock on max8997 PMIC */
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <32768>;
> + };
> };
>
> thermal-zones {
> @@ -444,10 +451,21 @@
> regulator-name = "SAFEOUT2";
> regulator-boot-on;
> };
> +
> + EN32KHZ_AP {
> + regulator-name = "EN32KHZ_AP";
> + regulator-always-on;
> + };
> };
> };
> };
>
> +&rtc {
> + status = "okay";
> + clocks = <&clock CLK_RTC>, <&pmic_ap_clk>;
> + clock-names = "rtc", "rtc_src";
> +};
> +
> &sdhci_0 {
> bus-width = <8>;
> non-removable;
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-08-31 9:49 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 13:51 [PATCH 01/33] ARM: dts: exynos: Silence i2c-gpio dtschema warning in Galaxy I9100 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 02/33] ARM: dts: exynos: Correct GPU regulator properties " Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 03/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it " Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 04/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it in Origen Krzysztof Kozlowski
2020-08-31 9:49 ` Marek Szyprowski
2020-08-30 13:51 ` [PATCH 05/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it in Trats Krzysztof Kozlowski
2020-08-31 9:49 ` Marek Szyprowski [this message]
2020-08-30 13:51 ` [PATCH 06/33] ARM: dts: exynos: Correct S3C RTC bindings and enable it in Universal C210 Krzysztof Kozlowski
2020-08-31 9:49 ` Marek Szyprowski
2020-08-30 13:51 ` [PATCH 07/33] ARM: dts: exynos: Correct S3C RTC bindings in SMDKv310 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 08/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Galaxy I9100 Krzysztof Kozlowski
2020-09-02 15:41 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 09/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Origen Krzysztof Kozlowski
2020-08-31 9:16 ` Marek Szyprowski
2020-08-31 9:37 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 10/33] ARM: dts: exynos: Add and enable 32 kHz modem clock in Trats Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 11/33] ARM: dts: exynos: Remove empty camera pinctrl configuration " Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 12/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Universal C210 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 13/33] ARM: dts: exynos: Align SPI GPIO node name with dtschema " Krzysztof Kozlowski
2020-08-30 13:51 ` [RFT 14/33] ARM: dts: exynos: Replace deprecated GPIO spi-gpio properties " Krzysztof Kozlowski
2020-08-31 9:25 ` Marek Szyprowski
2020-08-30 13:51 ` [PATCH 15/33] ARM: dts: exynos: Align SPI GPIO node name with dtschema in Galaxy I9100 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 16/33] ARM: dts: exynos: Override thermal by label in Exynos4210 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 17/33] ARM: dts: exynos: Override thermal by label in Galaxy I9000 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 18/33] ARM: dts: exynos: Override thermal by label in Trats Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 19/33] ARM: dts: exynos: Add CPU cooling in Origen Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 20/33] ARM: dts: exynos: Add CPU cooling in SMDKv310 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 21/33] ARM: dts: exynos: Add CPU cooling in Universal C210 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 22/33] ARM: dts: exynos: Align MHL GPIO pin configuration with dtschema on Galaxy I9100 Krzysztof Kozlowski
2020-09-02 15:45 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3 Krzysztof Kozlowski
2020-08-31 8:31 ` Marek Szyprowski
2020-08-31 8:38 ` Krzysztof Kozlowski
2020-08-31 8:44 ` Marek Szyprowski
2020-08-31 10:35 ` Sylwester Nawrocki
2020-08-31 10:42 ` Krzysztof Kozlowski
2020-08-31 13:57 ` Sylwester Nawrocki
2020-08-31 13:59 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 24/33] ARM: dts: exynos: Correct compatible of fixed clocks in Midas boards Krzysztof Kozlowski
2020-09-02 15:48 ` Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 25/33] ARM: dts: exynos: Add S5M8767 clocks for RTC in Exynos4412 Origen Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 26/33] ARM: dts: exynos: Override thermal by label in Midas Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 27/33] ARM: dts: exynos: Override thermal by label in Exynos4412 Odroids Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 28/33] ARM: dts: exynos: Add CPU cooling in Exynos4412 Origen Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 29/33] ARM: dts: exynos: Add CPU cooling in SMDK4412 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 30/33] ARM: dts: exynos: Add CPU cooling in Tiny4412 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 31/33] ARM: dts: exynos: Correct S3C RTC bindings in SMDK4412 Krzysztof Kozlowski
2020-08-30 13:51 ` [PATCH 32/33] ARM: dts: exynos: Correct S3C RTC bindings in Tiny4412 Krzysztof Kozlowski
2020-08-30 13:52 ` [PATCH 33/33] ARM: dts: exynos: Correct whitespace and indentation issues Krzysztof Kozlowski
2020-09-02 15:38 ` [PATCH 01/33] ARM: dts: exynos: Silence i2c-gpio dtschema warning in Galaxy I9100 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22b599d2-57a4-54d1-c68f-015e201a7415@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=GNUtoo@cyberdimension.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=simon@lineageos.org \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).