From: Chanwoo Choi <cw00.choi@samsung.com>
To: Leonard Crestez <leonard.crestez@nxp.com>,
"krzk@kernel.org" <krzk@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"heiko@sntech.de" <heiko@sntech.de>,
"lukasz.luba@arm.com" <lukasz.luba@arm.com>,
"a.swigon@samsung.com" <a.swigon@samsung.com>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"kgene@kernel.org" <kgene@kernel.org>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH 2/9] PM / devfreq: Remove devfreq_get_devfreq_by_phandle function
Date: Wed, 18 Dec 2019 12:20:14 +0900 [thread overview]
Message-ID: <304cb931-46da-d525-811d-51d932081b84@samsung.com> (raw)
In-Reply-To: <1967cf03-d1e8-8197-c767-3c8d5f403708@samsung.com>
On 12/18/19 11:59 AM, Chanwoo Choi wrote:
> On 12/17/19 11:33 PM, Leonard Crestez wrote:
>> On 17.12.2019 07:51, Chanwoo Choi wrote:
>>> Previously, devfreq core support 'devfreq' property in order to get
>>> the devfreq device by phandle. But, 'devfreq' property name is not proper
>>> on devicetree binding because this name doesn't mean the any h/w attribute.
>>>
>>> The devfreq core hand over the right to decide the property name
>>> for getting the devfreq device on devicetree. Each devfreq driver
>>> will decide the property name on devicetree binding and then get
>>> the devfreq device by using devfreq_get_devfreq_by_node().
>>>
>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> ---
>>> drivers/devfreq/devfreq.c | 35 -----------------------------------
>>> drivers/devfreq/exynos-bus.c | 14 ++++++++++++--
>>> include/linux/devfreq.h | 8 --------
>>> 3 files changed, 12 insertions(+), 45 deletions(-)
>>>
>>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>>> index cb8ca81c8973..c3d3c7c802a0 100644
>>> --- a/drivers/devfreq/devfreq.c
>>> +++ b/drivers/devfreq/devfreq.c
>>> @@ -991,48 +991,13 @@ struct devfreq *devfreq_get_devfreq_by_node(struct device_node *node)
>>>
>>> return ERR_PTR(-ENODEV);
>>> }
>>> -
>>> -/*
>>> - * devfreq_get_devfreq_by_phandle - Get the devfreq device from devicetree
>>> - * @dev - instance to the given device
>>> - * @index - index into list of devfreq
>>> - *
>>> - * return the instance of devfreq device
>>> - */
>>> -struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev, int index)
>>> -{
>>> - struct device_node *node;
>>> - struct devfreq *devfreq;
>>> -
>>> - if (!dev)
>>> - return ERR_PTR(-EINVAL);
>>> -
>>> - if (!dev->of_node)
>>> - return ERR_PTR(-EINVAL);
>>> -
>>> - node = of_parse_phandle(dev->of_node, "devfreq", index);
>>> - if (!node)
>>> - return ERR_PTR(-ENODEV);
>>> -
>>> - devfreq = devfreq_get_devfreq_by_node(node);
>>> - of_node_put(node);
>>> -
>>> - return devfreq;
>>> -}
>>> -
>>> #else
>>> struct devfreq *devfreq_get_devfreq_by_node(struct device_node *node)
>>> {
>>> return ERR_PTR(-ENODEV);
>>> }
>>> -
>>> -struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev, int index)
>>> -{
>>> - return ERR_PTR(-ENODEV);
>>> -}
>>> #endif /* CONFIG_OF */
>>> EXPORT_SYMBOL_GPL(devfreq_get_devfreq_by_node);
>>> -EXPORT_SYMBOL_GPL(devfreq_get_devfreq_by_phandle);
>>>
>>> /**
>>> * devm_devfreq_remove_device() - Resource-managed devfreq_remove_device()
>>> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
>>> index 7f5917d59072..9aac2db956d5 100644
>>> --- a/drivers/devfreq/exynos-bus.c
>>> +++ b/drivers/devfreq/exynos-bus.c
>>> @@ -146,6 +146,16 @@ static int exynos_bus_get_dev_status(struct device *dev,
>>> return ret;
>>> }
>>>
>>> +static struct devfreq *get_parent_devfreq_by_node(struct device_node *np)
>>> +{
>>> + struct device_node *node = of_parse_phandle(np, "devfreq", 0);
>>> +
>>> + if (!node)
>>> + return ERR_PTR(-ENODEV);
>>> +
>>> + return devfreq_get_devfreq_by_node(node);
>>> +}
>>
>> The _by_node suffix here is confusing because it actually fetches a
>> property of the node unlike devfreq_get_devfreq_by_node. Maybe call this
>> get_parent_devfreq_from_node?
>>
>> Since it's a static function it could just be called get_parent_devfreq?
>
> OK.
I'll rename as following because all functions of exynos-bus.c
which used 'exynos_bus_' prefix.
- exynos_bus_get_parent_devfreq()
>
>>
>>> +
>>> static void exynos_bus_exit(struct device *dev)
>>> {
>>> struct exynos_bus *bus = dev_get_drvdata(dev);
>>> @@ -353,8 +363,8 @@ static int exynos_bus_profile_init_passive(struct exynos_bus *bus,
>>> profile->exit = exynos_bus_passive_exit;
>>>
>>> /* Get the instance of parent devfreq device */
>>> - parent_devfreq = devfreq_get_devfreq_by_phandle(dev, 0);
>>> - if (IS_ERR(parent_devfreq))
>>> + parent_devfreq = get_parent_devfreq_by_node(dev->of_node);
>>> + if (IS_ERR(parent_devfreq)) {
>>> return -EPROBE_DEFER;
>>>
>>> passive_data = devm_kzalloc(dev, sizeof(*passive_data), GFP_KERNEL);
>>> diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
>>> index e3633ae43349..3ed96426302e 100644
>>> --- a/include/linux/devfreq.h
>>> +++ b/include/linux/devfreq.h
>>> @@ -254,8 +254,6 @@ extern void devm_devfreq_unregister_notifier(struct device *dev,
>>> struct notifier_block *nb,
>>> unsigned int list);
>>> extern struct devfreq *devfreq_get_devfreq_by_node(struct device_node *node);
>>> -extern struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev,
>>> - int index);
>>>
>>> #if IS_ENABLED(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND)
>>> /**
>>> @@ -413,12 +411,6 @@ struct devfreq *devfreq_get_devfreq_by_node(struct device_node *node)
>>> return ERR_PTR(-ENODEV);
>>> }
>>>
>>> -static inline struct devfreq *devfreq_get_devfreq_by_phandle(struct device *dev,
>>> - int index)
>>> -{
>>> - return ERR_PTR(-ENODEV);
>>> -}
>>> -
>>> static inline int devfreq_update_stats(struct devfreq *df)
>>> {
>>> return -EINVAL;
>>>
>>
>>
>>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2019-12-18 3:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191217055105epcas1p365e306f27fd53852b793155c929ee634@epcas1p3.samsung.com>
2019-12-17 5:57 ` [PATCH 0/9] PM / devfreq: Remove deprecated 'devfreq' and 'devfreq-events' properties Chanwoo Choi
[not found] ` <CGME20191217055105epcas1p3bacbf54550c52979fe819ab33bb21d30@epcas1p3.samsung.com>
2019-12-17 5:57 ` [PATCH 1/9] PM / devfreq: Add devfreq_get_devfreq_by_node function Chanwoo Choi
[not found] ` <CGME20191217055105epcas1p2d2930402a559e381a7854f515a683d15@epcas1p2.samsung.com>
2019-12-17 5:57 ` [PATCH 2/9] PM / devfreq: Remove devfreq_get_devfreq_by_phandle function Chanwoo Choi
2019-12-17 14:33 ` Leonard Crestez
2019-12-18 2:59 ` Chanwoo Choi
2019-12-18 3:20 ` Chanwoo Choi [this message]
[not found] ` <CGME20191217055106epcas1p3e77268d200006921dfa736b2c7550a04@epcas1p3.samsung.com>
2019-12-17 5:57 ` [PATCH 3/9] PM / devfreq: event: Add devfreq_event_get_edev_by_node function Chanwoo Choi
[not found] ` <CGME20191217055106epcas1p11f2bc81d6bb2db3fc4bc257d78c337b9@epcas1p1.samsung.com>
2019-12-17 5:57 ` [PATCH 4/9] PM / devfreq: exynos-bus: Replace deprecated 'devfreq' property Chanwoo Choi
2019-12-26 21:01 ` Rob Herring
2019-12-27 0:09 ` Chanwoo Choi
2020-01-06 1:38 ` Chanwoo Choi
2020-01-14 18:57 ` Chanwoo Choi
[not found] ` <CGME20191217055106epcas1p4b50ca647af9b54465e5c0a0bebb165b8@epcas1p4.samsung.com>
2019-12-17 5:57 ` [PATCH 5/9] PM / devfreq: exynos-bus: Replace deprecated 'devfreq-events' property Chanwoo Choi
[not found] ` <CGME20191217055106epcas1p156b1323f4ec9f7c35fed825d56e577ff@epcas1p1.samsung.com>
2019-12-17 5:57 ` [PATCH 6/9] PM / devfreq: rk3399_dmc: " Chanwoo Choi
[not found] ` <CGME20191217055106epcas1p2c43a45e34983c1b3e60cc6fd842dd33e@epcas1p2.samsung.com>
2019-12-17 5:57 ` [PATCH 7/9] memory: samsung: exynos5422-dmc: " Chanwoo Choi
2019-12-17 11:03 ` Lukasz Luba
2019-12-19 20:19 ` Krzysztof Kozlowski
[not found] ` <CGME20191217055106epcas1p4c0f65bec74e53b38d95e984e146bf8b6@epcas1p4.samsung.com>
2019-12-17 5:57 ` [PATCH 8/9] ARM: dts: exynos: Replace deprecated property for Exynos bus and DMC Chanwoo Choi
2019-12-19 20:21 ` Krzysztof Kozlowski
[not found] ` <CGME20191217055107epcas1p44d46bdea7b326b86689f326742f5444a@epcas1p4.samsung.com>
2019-12-17 5:57 ` [PATCH 9/9] arm64: dts: exynos: Replace deprecated property for Exynos bus Chanwoo Choi
2019-12-19 20:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=304cb931-46da-d525-811d-51d932081b84@samsung.com \
--to=cw00.choi@samsung.com \
--cc=a.swigon@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).