From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Tzung-Bi Shih <tzungbi@google.com>,
ALSA development <alsa-devel@alsa-project.org>,
Dylan Reid <dgreid@google.com>,
Jimmy Cheng-Yi Chiang <cychiang@google.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Takashi Iwai <tiwai@suse.de>
Subject: Re: [alsa-devel] [PATCH v2] ASoC: max98090: save and restore SHDN when changing sensitive registers
Date: Fri, 20 Dec 2019 10:05:52 +0100 [thread overview]
Message-ID: <31bde14e-1fef-264a-ba1e-fc3051506bf3@samsung.com> (raw)
In-Reply-To: <b0e57646-8a14-e6c0-9daa-28c353dcb77a@samsung.com>
Hi All,
On 20.12.2019 09:28, Marek Szyprowski wrote:
> On 19.12.2019 20:16, Mark Brown wrote:
>> On Thu, Dec 19, 2019 at 02:41:17PM +0100, Marek Szyprowski wrote:
>>> On 19.12.2019 14:05, Mark Brown wrote:
>>>> You can't trigger this via any other mechanism, all the other controls
>>>> are fine? There's *clearly* no issue with what the commit is doing,
>>>> it's just flagging up that the card is not set.
>>> I've cherrypicked the $subject commit onto vanilla v5.5-rc1 and the
>>> issue is same.
>> Yeah, there were a lot of refactorings in the last merge window so that
>> doesn't entirely surprise me. The commit should backport futher than
>> that I think?
>
> I've tried initially to cherry-pick it to v5.4, but the the code
> didn't compile due to lack of some macros, so I've gave up trying. I
> will check that now and backport needed macros too if you think this
> would help.
Same issue. I've tried backporting it to each kernel release: 5.4, 5.3,
5.2, 5.1 and 5.0 (with additional backporting "ASoC: core: add
SND_SOC_BYTES_E" and "ASoC: Define a set of DAPM pre/post-up events").
In all cases the lockdep warning and oops is the same. Backporting to
v4.9 requires more changes to get it even compiled, so I gave up.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2019-12-20 9:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191128152110epcas3p2b205b4b55f6d8bfac42fcb8faaade93c@epcas3p2.samsung.com>
[not found] ` <20191128151908.180871-1-tzungbi@google.com>
2019-12-12 14:09 ` [alsa-devel] [PATCH v2] ASoC: max98090: save and restore SHDN when changing sensitive registers Marek Szyprowski
2019-12-12 16:02 ` Marek Szyprowski
2019-12-12 16:48 ` Mark Brown
2019-12-12 18:05 ` Tzung-Bi Shih
2019-12-17 14:18 ` Marek Szyprowski
2019-12-18 13:26 ` Mark Brown
2019-12-18 14:48 ` Marek Szyprowski
2019-12-18 16:24 ` Mark Brown
2019-12-19 8:03 ` Marek Szyprowski
2019-12-19 12:37 ` Mark Brown
2019-12-19 12:54 ` Marek Szyprowski
2019-12-19 13:05 ` Mark Brown
2019-12-19 13:41 ` Marek Szyprowski
2019-12-19 19:16 ` Mark Brown
2019-12-20 8:28 ` Marek Szyprowski
2019-12-20 9:05 ` Marek Szyprowski [this message]
2019-12-20 12:01 ` Mark Brown
2020-01-08 11:54 ` Marek Szyprowski
2020-01-09 21:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31bde14e-1fef-264a-ba1e-fc3051506bf3@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cychiang@google.com \
--cc=dgreid@google.com \
--cc=krzk@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tiwai@suse.de \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).