From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hyunki Koo <hyunki00.koo@samsung.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
s.nawrocki@samsung.com, linus.walleij@linaro.org,
linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-gpio@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: samsung: modularize samsung pinctrl driver
Date: Wed, 27 Nov 2019 09:58:04 +0800 [thread overview]
Message-ID: <CAJKOXPdDYv2McfMPabmTkhDFFL-68yHqcOOTCw75=+HpCRRHMg@mail.gmail.com> (raw)
In-Reply-To: <CAJKOXPdy=oxkwspt3CpF-qV5XRPMKrupMOpbWXJT3e7trqvXkw@mail.gmail.com>
On Tue, 26 Nov 2019 at 14:09, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Tue, 26 Nov 2019 at 09:14, Hyunki Koo <hyunki00.koo@samsung.com> wrote:
> >
> > On Thu, 21 Nov 2019 at 16:38, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > Hi,
> > >
> > > Thanks for the patch. Few comments below:
> > >
> > > On Thu, 21 Nov 2019 at 15:26, 구현기 <hyunki00.koo@samsung.com> wrote:
> > >>
> > >> Enable samsung pinctrl driver to be compiled as modules.
> > >
> > > Why? What's the benefit? Are platforms capable of such boot? Pinctrl is needed early - even before mounting rootfs...
> > > What about module unloading? Is it reasonable?
> > > Please answer to all this also in commit message.
> > >
> >
> > Sorry to late and Thank you for your comment, I would like to apply GKI on the pinctrl driver
> > So I would like to cut off dependency from ARCH_EXYNOS.
>
> This is driver for Exynos and S3C so why cutting off the dependency? I
> mean, wait, it is a driver for Exynos so it cannot work on other
> boards...
One more thought about Generic Kernel Image for Android. It implies
that vendor stuff will be in modules... but only for out-of-tree code.
The Exynos pinctrl driver is already in mainline so moving it into
module is not necessary.
As for dependency on ARCH_EXYNOS - I do not get why this is a problem.
ARCH_EXYNOS is multiplatform ready so you can boot multi_v7... What
would be the benefit of removing this dependency?
Best regards,
Krzysztof
next prev parent reply other threads:[~2019-11-27 1:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191121072643epcas2p452071a503725c7764acf5084d24425b1@epcas2p4.samsung.com>
2019-11-21 7:26 ` [PATCH] pinctrl: samsung: modularize samsung pinctrl driver 구현기
2019-11-21 7:38 ` Krzysztof Kozlowski
2019-11-26 1:14 ` Hyunki Koo
2019-11-26 6:09 ` Krzysztof Kozlowski
2019-11-27 1:58 ` Krzysztof Kozlowski [this message]
2019-11-27 7:58 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPdDYv2McfMPabmTkhDFFL-68yHqcOOTCw75=+HpCRRHMg@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=hyunki00.koo@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).