From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1387C4320A for ; Thu, 12 Aug 2021 17:42:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87A09610A7 for ; Thu, 12 Aug 2021 17:42:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236627AbhHLRnW (ORCPT ); Thu, 12 Aug 2021 13:43:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236698AbhHLRnV (ORCPT ); Thu, 12 Aug 2021 13:43:21 -0400 Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [IPv6:2607:f8b0:4864:20::e31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD410C0617AE for ; Thu, 12 Aug 2021 10:42:55 -0700 (PDT) Received: by mail-vs1-xe31.google.com with SMTP id b10so4409189vsp.2 for ; Thu, 12 Aug 2021 10:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pHcu02xjOvcoHo6AbRKwnHr9phI93JJT0Rao79sK4fo=; b=CY7P/qzMEfBWXRXWKtR8v3VIuuPEUTnqMj0u0IlCjx2QDJfDtzzz5lAn+EAznQAneF OeWlNzivncUgCO7bzYexiHsPY/CRSggh2agt1Ez31UxHgrVQdIXuytgTDq+H82nmqjA4 i0mjeY2KyH2Q6OSZnwb3lY7lCTuvQVZ77AN1v1aAA83Mt7onfoLNG1WExeFC4KhI0Qln AyvwZu1891Kzh9+M0C21GkqPtBDpKpQQPTzLCdC3/dmlWeihD7Tdr+lB5yO4+uRpXKgu 3+TCnWgQCcvKdbJBMhIErwHLGFJLtc852fDGbOAaUUQZx6oYYQhsbiEj5j/gNeIx1at6 VFPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pHcu02xjOvcoHo6AbRKwnHr9phI93JJT0Rao79sK4fo=; b=Od3ExVSfbuWFREB++DE7T5VnKgM24rRngp3NZXjer85cNcPr5+kaqyfqgDZvbSTacP b9ebZjLVYPvYmIx4DM0oG0wDSZR9YzSk/PImc1BUZH/8W6hIWelSGQiRCDlR/uDFTwSO IXKYX0IapG1/sBdmtitzmgEsPoiJDZOvj+/yOuJ5EXfqJUro/3cFdMndacVAQy3t/DQJ uHlGWwEFwnU0sOpRSHqSnfF/LYxUQEuhVsv+9Tt+UUYvI0f+NrCMorkm1fmYFeBvKp4q F+Li5mN13xvFWKK8NNvpXDKDb1rXZuKgvA93HIlG6Zv3ku0t5jASBskeRRK9Tyr9GzLq eumQ== X-Gm-Message-State: AOAM532F3yf3g25Aijr9kpfgIdU8IKnRSTYHSI/JkdI4shdIa0eT1ogE j3n9jiDwK21cR+N4BZqbt1uBYrutWWsbgppJGI73hQ== X-Google-Smtp-Source: ABdhPJyNdy6bFAJh3di+xXMWYOdrbqmE60K4KYshjevA5Dh2cB8VNc1oON29cKkkSDB7/alTy5xFtUXQbdQqfhTkXHc= X-Received: by 2002:a67:c414:: with SMTP id c20mr4410818vsk.27.1628790174642; Thu, 12 Aug 2021 10:42:54 -0700 (PDT) MIME-Version: 1.0 References: <20210811114827.27322-1-semen.protsenko@linaro.org> <20210811114827.27322-8-semen.protsenko@linaro.org> In-Reply-To: From: Sam Protsenko Date: Thu, 12 Aug 2021 20:42:42 +0300 Message-ID: Subject: Re: [PATCH v3 7/7] arm64: dts: exynos: Add Exynos850 SoC support To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , =?UTF-8?Q?Pawe=C5=82_Chmiel?= , Chanwoo Choi , Linus Walleij , Tomasz Figa , Marc Zyngier , Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree , linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linux Samsung SOC , "open list:SERIAL DRIVERS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Thu, 12 Aug 2021 at 11:17, Krzysztof Kozlowski wrote: > > On 11/08/2021 13:48, Sam Protsenko wrote: > > Samsung Exynos850 is ARMv8-based mobile-oriented SoC. > > > > This patch adds minimal SoC support by including next Device Tree nodes: > > > > 1. Octa cores (Cortex-A55), supporting PSCI v1.0 > > 2. ARM architecture timer (armv8-timer) > > 3. Interrupt controller (GIC-400) > > 4. Pinctrl nodes for GPIO > > 5. Serial node > > > > Signed-off-by: Sam Protsenko > > --- > > Changes in v3: > > - Used generic fixed clock for serial > > > > Changes in v2: > > * Commit message: > > - Documented added dts features instead of CPU features > > > > * exynos850-usi.dtsi: > > - Removed, moved everything to exynos850.dtsi > > > > * exynos850.dtsi: > > - Root node: > > - Added comment about engineering name (Exynos3830) > > - Renamed pinctrl nodes, adding domain names > > - Used hard coded IRQ numbers instead of named constants everywhere > > - Added soc node, moved next nodes there: gic, clock, pinctrls and > > serial > > - Used address-cells=1 for soc node and removed unneeded 0x0 from > > reg properties > > - Moved exynos850-pinctrl.dtsi include line to the end of > > exynos850.dtsi > > - Coding style fixes > > - cpus: > > - Used address-cells=1 for cpus node > > - Renamed cpu@0001 to cpu@1, and so on > > - Left only "arm,cortex-a55" for cpus compatible > > - Renamed reg = <0x0001> to <0x1> for cpus > > - armv8 timer: > > - Add comment about missing HV timer IRQ to armv8 timer node > > - Removed not existing properties from armv8 timer node > > - Fixed cpu number in CPU_MASK() > > - Removed obsolete clock-frequency property > > - GIC: > > - Fixed GIC type to be GIC-400 > > - Fixed size of GIC's 2nd region to be 0x2000 > > - serial node: > > - Hard coded clock number for serial_0 for now; will replace with > > named const once proper clock driver is implemented > > - Removed gate_uart_clk0 clock from serial_0, as that clock is not > > supported in serial driver anyway (yet) > > - clock node: > > - Fixed clock controller node name (@0x12.. -> @12..) > > > > * exynos850-pinctrl.dtsi: > > - Referenced pinctrl nodes instead of defining those again in root node > > - Fixed interrupt-cells (3 -> 2) > > - Fixed USI related comments for pin config nodes > > - Removed decon_f_te_* and fm_lna_en nodes (won't be used) > > - Reordered pin config nodes by pin numbers > > - Improved all comments > > - Used existing named constants for pin-function and pin-pud > > - Fixed node names (used hyphens instead of underscore) > > - Fixed warnings found in W=1 build > > > > .../boot/dts/exynos/exynos850-pinctrl.dtsi | 748 ++++++++++++++++++ > > arch/arm64/boot/dts/exynos/exynos850.dtsi | 261 ++++++ > > 2 files changed, 1009 insertions(+) > > create mode 100644 arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi > > create mode 100644 arch/arm64/boot/dts/exynos/exynos850.dtsi > > > > diff --git a/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi > > new file mode 100644 > > index 000000000000..ba5d5f33e2f6 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi > > @@ -0,0 +1,748 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Samsung's Exynos850 SoC pin-mux and pin-config device tree source > > + * > > + * Copyright (C) 2017 Samsung Electronics Co., Ltd. > > + * Copyright (C) 2021 Linaro Ltd. > > + * > > + * Samsung's Exynos850 SoC pin-mux and pin-config options are listed as device > > + * tree nodes in this file. > > + */ > > + > > +#include > > +#include > > + > > +&pinctrl_alive { > > + gpa0: gpa0 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + interrupt-parent = <&gic>; > > + interrupts = , > > + , > > + , > > + , > > + , > > + , > > + , > > + ; > > + }; > > + > > + gpa1: gpa1 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + interrupt-parent = <&gic>; > > + interrupts = , > > + , > > + , > > + , > > + , > > + , > > + , > > + ; > > + }; > > + > > + gpa2: gpa2 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + interrupt-parent = <&gic>; > > + interrupts = , > > + , > > + , > > + , > > + , > > + , > > + , > > + ; > > + }; > > + > > + gpa3: gpa3 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + interrupt-parent = <&gic>; > > + interrupts = , > > + , > > + , > > + , > > + , > > + , > > + , > > + ; > > + }; > > + > > + gpa4: gpa4 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + interrupt-parent = <&gic>; > > + interrupts = , > > + , > > + , > > + ; > > + }; > > + > > + gpq0: gpq0 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + /* I2C5 (also called CAM_PMIC_I2C in TRM) */ > > + i2c5_bus: i2c5-bus { > > + samsung,pins = "gpa3-5", "gpa3-6"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + /* I2C6 (also called MOTOR_I2C in TRM) */ > > + i2c6_bus: i2c6-bus { > > + samsung,pins = "gpa3-7", "gpa4-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + /* USI: UART */ > > + uart0_bus: uart0-bus { > > + samsung,pins = "gpq0-0", "gpq0-1"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > +}; > > + > > +&pinctrl_cmgp { > > + gpm0: gpm0 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + interrupt-parent = <&gic>; > > + interrupts = ; > > + }; > > + > > + gpm1: gpm1 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + interrupt-parent = <&gic>; > > + interrupts = ; > > + }; > > + > > + gpm2: gpm2 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + interrupt-parent = <&gic>; > > + interrupts = ; > > + }; > > + > > + gpm3: gpm3 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + interrupt-parent = <&gic>; > > + interrupts = ; > > + }; > > + > > + gpm4: gpm4 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + interrupt-parent = <&gic>; > > + interrupts = ; > > + }; > > + > > + gpm5: gpm5 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + interrupt-parent = <&gic>; > > + interrupts = ; > > + }; > > + > > + /* USI_CMGP0: HSI2C function */ > > + hsi2c3_bus: hsi2c3-bus { > > + samsung,pins = "gpm0-0", "gpm1-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > There are also macros for DRV. > Unfortunately, existing DRV macros won't work for Exynos850. DRV constants have different meaning for different GPIO domains in Exynos850, so I thought introducing several groups of DRV constants might be confusing. But please let me know if you still want me do that. > I assume you checked whether the actual values of FUNC/PULL/DRV macros > match Exynos850 datasheet. > Yep, they are good. > > + }; > > + > > + /* USI_CMGP0: UART function (4 pins, Auto Flow Control) */ > > + uart1_bus_single: uart1-bus { > > + samsung,pins = "gpm0-0", "gpm1-0", "gpm2-0", "gpm3-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > + > > + /* USI_CMGP0: UART function (2 pins, Non-Auto Flow Control) */ > > + uart1_bus_dual: uart1-bus-dual { > > + samsung,pins = "gpm0-0", "gpm1-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > + > > + /* USI_CMGP0: SPI function */ > > + spi1_bus: spi1-bus { > > + samsung,pins = "gpm0-0", "gpm1-0", "gpm2-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + spi1_cs: spi1-cs { > > + samsung,pins = "gpm3-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + spi1_cs_func: spi1-cs-func { > > + samsung,pins = "gpm3-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + /* USI_CMGP1: HSI2C function */ > > + hsi2c4_bus: hsi2c4-bus { > > + samsung,pins = "gpm4-0", "gpm5-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + /* USI_CMGP1: UART function (4 pins, Auto Flow Control) */ > > + uart2_bus_single: uart2-bus { > > + samsung,pins = "gpm4-0", "gpm5-0", "gpm6-0", "gpm7-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > + > > + /* USI_CMGP1: UART function (2 pins, Non-Auto Flow Control) */ > > + uart2_bus_dual: uart2-bus-dual { > > + samsung,pins = "gpm4-0", "gpm5-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > + > > + /* USI_CMGP1: SPI function */ > > + spi2_bus: spi2-bus { > > + samsung,pins = "gpm4-0", "gpm5-0", "gpm6-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + spi2_cs: spi2-cs { > > + samsung,pins = "gpm7-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + spi2_cs_func: spi2-cs-func { > > + samsung,pins = "gpm7-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > +}; > > + > > +&pinctrl_aud { > > + gpb0: gpb0 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + gpb1: gpb1 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + aud_codec_mclk: aud-codec-mclk { > > + samsung,pins = "gpb0-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > + > > + aud_codec_mclk_idle: aud-codec-mclk-idle { > > + samsung,pins = "gpb0-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > + > > + aud_i2s0_bus: aud-i2s0-bus { > > + samsung,pins = "gpb0-1", "gpb0-2", "gpb0-3", "gpb0-4"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > + > > + aud_i2s0_idle: aud-i2s0-idle { > > + samsung,pins = "gpb0-1", "gpb0-2", "gpb0-3", "gpb0-4"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > + > > + aud_i2s1_bus: aud-i2s1-bus { > > + samsung,pins = "gpb1-0", "gpb1-1", "gpb1-2", "gpb1-3"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > + > > + aud_i2s1_idle: aud-i2s1-idle { > > + samsung,pins = "gpb1-0", "gpb1-1", "gpb1-2", "gpb1-3"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > + > > + aud_fm_bus: aud-fm-bus { > > + samsung,pins = "gpb1-4"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > + > > + aud_fm_idle: aud-fm-idle { > > + samsung,pins = "gpb1-4"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > +}; > > + > > +&pinctrl_hsi { > > + gpf2: gpf2 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + sd2_clk: sd2-clk { > > + samsung,pins = "gpf2-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <2>; > > + }; > > + > > + sd2_clk_fast_slew_rate_1x: sd2-clk-fast-slew-rate-1x { > > + samsung,pins = "gpf2-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + sd2_clk_fast_slew_rate_1_5x: sd2-clk-fast-slew-rate-1-5x { > > + samsung,pins = "gpf2-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <1>; > > + }; > > + > > + sd2_clk_fast_slew_rate_2x: sd2-clk-fast-slew-rate-2x { > > + samsung,pins = "gpf2-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <2>; > > + }; > > + > > + sd2_clk_fast_slew_rate_2_5x: sd2-clk-fast-slew-rate-2-5x { > > + samsung,pins = "gpf2-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <3>; > > + }; > > + > > + sd2_clk_fast_slew_rate_3x: sd2-clk-fast-slew-rate-3x { > > + samsung,pins = "gpf2-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <4>; > > + }; > > + > > + sd2_clk_fast_slew_rate_4x: sd2-clk-fast-slew-rate-4x { > > + samsung,pins = "gpf2-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <5>; > > + }; > > + > > + sd2_cmd: sd2-cmd { > > + samsung,pins = "gpf2-1"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <2>; > > + }; > > + > > + sd2_bus1: sd2-bus-width1 { > > + samsung,pins = "gpf2-2"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <2>; > > + }; > > + > > + sd2_bus4: sd2-bus-width4 { > > + samsung,pins = "gpf2-3", "gpf2-4", "gpf2-5"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <2>; > > + }; > > + > > + sd2_pins_as_pdn: sd2-pins-as-pdn { > > + samsung,pins = "gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3", > > + "gpf2-4", "gpf2-5"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + }; > > +}; > > + > > +&pinctrl_core { > > + gpf0: gpf0 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + gpf1: gpf1 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + sd0_clk: sd0-clk { > > + samsung,pins = "gpf0-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <3>; > > + }; > > + > > + sd0_clk_fast_slew_rate_1x: sd0-clk-fast-slew-rate-1x { > > + samsung,pins = "gpf0-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <1>; > > + }; > > + > > + sd0_clk_fast_slew_rate_2x: sd0-clk-fast-slew-rate-2x { > > + samsung,pins = "gpf0-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <2>; > > + }; > > + > > + sd0_clk_fast_slew_rate_3x: sd0-clk-fast-slew-rate-3x { > > + samsung,pins = "gpf0-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <2>; > > + }; > > + > > + sd0_clk_fast_slew_rate_4x: sd0-clk-fast-slew-rate-4x { > > + samsung,pins = "gpf0-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <3>; > > + }; > > + > > + sd0_cmd: sd0-cmd { > > + samsung,pins = "gpf0-1"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <3>; > > + }; > > + > > + sd0_rdqs: sd0-rdqs { > > + samsung,pins = "gpf0-2"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <3>; > > + }; > > + > > + sd0_nreset: sd0-nreset { > > + samsung,pins = "gpf0-3"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <3>; > > + }; > > + > > + sd0_bus1: sd0-bus-width1 { > > + samsung,pins = "gpf1-0"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <3>; > > + }; > > + > > + sd0_bus4: sd0-bus-width4 { > > + samsung,pins = "gpf1-1", "gpf1-2", "gpf1-3"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <3>; > > + }; > > + > > + sd0_bus8: sd0-bus-width8 { > > + samsung,pins = "gpf1-4", "gpf1-5", "gpf1-6", "gpf1-7"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <3>; > > + }; > > +}; > > + > > +&pinctrl_peri { > > + gpg0: gpg0 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + gpp0: gpp0 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + gpp1: gpp1 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + gpp2: gpp2 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + gpg1: gpg1 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + gpg2: gpg2 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + gpg3: gpg3 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + gpc0: gpc0 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + gpc1: gpc1 { > > + gpio-controller; > > + #gpio-cells = <2>; > > + > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + }; > > + > > + /* USI: HSI2C0 */ > > + hsi2c0_bus: hsi2c0-bus { > > + samsung,pins = "gpc1-0", "gpc1-1"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + /* USI: HSI2C1 */ > > + hsi2c1_bus: hsi2c1-bus { > > + samsung,pins = "gpc1-2", "gpc1-3"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + /* USI: HSI2C2 */ > > + hsi2c2_bus: hsi2c2-bus { > > + samsung,pins = "gpc1-4", "gpc1-5"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + /* USI: SPI */ > > + spi0_bus: spi0-bus { > > + samsung,pins = "gpp2-0", "gpp2-2", "gpp2-3"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + spi0_cs: spi0-cs { > > + samsung,pins = "gpp2-1"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + spi0_cs_func: spi0-cs-func { > > + samsung,pins = "gpp2-1"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + i2c0_bus: i2c0-bus { > > + samsung,pins = "gpp0-0", "gpp0-1"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + i2c1_bus: i2c1-bus { > > + samsung,pins = "gpp0-2", "gpp0-3"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + i2c2_bus: i2c2-bus { > > + samsung,pins = "gpp0-4", "gpp0-5"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + i2c3_bus: i2c3-bus { > > + samsung,pins = "gpp1-0", "gpp1-1"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + i2c4_bus: i2c4-bus { > > + samsung,pins = "gpp1-2", "gpp1-3"; > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <0>; > > + }; > > + > > + sensor_mclk0_in: sensor-mclk0-in { > > + samsung,pins = "gpc0-0"; > > All these gpc0 go before hsi2c0_bus node (to have them ordered by > datasheet pin name). > Done. > > + samsung,pin-function = ; > > + samsung,pin-pud = ; > > + samsung,pin-drv = <2>; > > + }; > > + > > Rest looks good but anyway will wait for the board DTS. :) > Sure. I'll probably send next patch series only when the board gets announced, and will include board's dts of course. > Best regards, > Krzysztof