From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AF5EC433F5 for ; Tue, 5 Oct 2021 11:36:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 233036126A for ; Tue, 5 Oct 2021 11:36:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234229AbhJELiR (ORCPT ); Tue, 5 Oct 2021 07:38:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233739AbhJELiP (ORCPT ); Tue, 5 Oct 2021 07:38:15 -0400 Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55C93C061749 for ; Tue, 5 Oct 2021 04:36:24 -0700 (PDT) Received: by mail-vs1-xe33.google.com with SMTP id 188so23356922vsv.0 for ; Tue, 05 Oct 2021 04:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fbUrctBKF1q2sRHPfrxPaFZV6eVVnBEbm2AjMWQx1J8=; b=vNcozf2V7CBmO3wgShgy8OiWUKPbUz6wjnSDrxeu3/go7vUY7Cp9uB37og1u0TJejg GfAFNpgZlwVyjj8rE77gMsKhtBefzGSjNk+ADIJQEWxi4edZxPH/cnDmlyG8TgOr3QLl BqgTEWM+k6pEDUmhxAMW1AGT/UDb1nfz+lFCje5CquyiY/1Y3/xaWKf9BusY1D9KxCYG dyDIg/qua8rZiOiCiTnOeyAHpB751d59JXqFdzUgbEycBPpVNnyDEAOg8Zu7yTgG5n5K 24Am8mHO8I/M/0KTFWWREbbPuZTSMjLMOZW6JhUbBvy2vpBt4TU5MBl6bqVNOV/OkvFF n01A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fbUrctBKF1q2sRHPfrxPaFZV6eVVnBEbm2AjMWQx1J8=; b=4aaXBksbTn7DElrJYBj90R3M/qSuC1FOmzHarPQSdG07U5UA7meFRYKLprSdBAoMFr 2rdY5zDLxQLohyUBjcOd8dBt8CvL2ut7Z8T91B39EByVw/F1agqey4qSyp9Hk8iEe98Z xdC+PXnJTLMsBl4zzkqkkvdfFGnbIAVfzlWK76rhMxnT6aLQcY4G5J35G58rW96T/u6X ztbADIoWc+yTxwept120s4hhCNVWE9VxLi9WZjvk2rugRrR5DJetExqWi7Iwdkq/zvLb uQpaeMUeqDD26AcPXKJRb6PZZ04cFzxkDnVqWscd/uQYzo+P4FO24tUb1AqFlnCv+i3Y xwEw== X-Gm-Message-State: AOAM530o57Y7iTw7B+wfyp7TWGTatOXsxQ8Iy0tSFaXfDtOlTHg0IE6m 5UwUrHw+d3XJwiPYAan++ODkhGatWa1b2zr0aGZaqg== X-Google-Smtp-Source: ABdhPJyXsDJFqKaDflnYIDcHflEgkdJaebxTVjcU4aa5qBIzEZojilMzGQI0T8ry8dqfIPcOqyiIfB693fyiZ0tMOmU= X-Received: by 2002:a67:d91b:: with SMTP id t27mr8819214vsj.55.1633433783316; Tue, 05 Oct 2021 04:36:23 -0700 (PDT) MIME-Version: 1.0 References: <20210914155607.14122-1-semen.protsenko@linaro.org> <20210914155607.14122-7-semen.protsenko@linaro.org> <1d884e38-ac8c-6f0c-ad27-243c5c4b9b9b@samsung.com> In-Reply-To: <1d884e38-ac8c-6f0c-ad27-243c5c4b9b9b@samsung.com> From: Sam Protsenko Date: Tue, 5 Oct 2021 14:36:11 +0300 Message-ID: Subject: Re: [PATCH 6/6] clk: samsung: Introduce Exynos850 clock driver To: Sylwester Nawrocki Cc: Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree , linux-arm Mailing List , linux-clk , Linux Kernel Mailing List , Linux Samsung SOC , Michael Turquette , Stephen Boyd , Rob Herring , Tomasz Figa , Chanwoo Choi , =?UTF-8?Q?Pawe=C5=82_Chmiel?= , Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, 15 Sept 2021 at 16:07, Sylwester Nawrocki wrote: > > On 14.09.2021 17:56, Sam Protsenko wrote: > > +static void __init exynos850_cmu_top_init(struct device_node *np) > > +{ > > + exynos850_init_clocks(np, top_clk_regs, ARRAY_SIZE(top_clk_regs)); > > + samsung_cmu_register_one(np, &top_cmu_info); > > +} > > + > > +CLK_OF_DECLARE(exynos850_cmu_top, "samsung,exynos850-cmu-top", > > + exynos850_cmu_top_init); > > Was there anything preventing you from making it a platform driver instead? > Can you please elaborate on benefits of adding platform driver? I don't implement PM ops for now, and I can see that clk-exynos7.c does not add platform driver as well... clk-exynos5433.c seems to use platform_driver for PM ops only. > -- > Regards, > Sylwester