From: Henrik Grimler <henrik@grimler.se>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: sre@kernel.org, linux-pm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht, wolfgit@wiedmeyer.de
Subject: Re: [PATCH 1/1] power: supply: max17042_battery: use VFSOC for capacity when no rsns
Date: Tue, 28 Sep 2021 21:18:44 +0200 [thread overview]
Message-ID: <YVNqlIIAJNil5MFL@grimlerstat.localdomain> (raw)
In-Reply-To: <febc15c6-8a40-cc0c-d98c-bbefc9cc953d@canonical.com>
On Tue, Sep 28, 2021 at 11:22:15AM +0200, Krzysztof Kozlowski wrote:
> On 19/09/2021 22:07, Henrik Grimler wrote:
> > On Galaxy S3 (i9300/i9305), which has the max17047 fuel gauge and no
> > current sense resistor (rsns), the RepSOC register does not provide an
> > accurate state of charge value. The reported value is wrong, and does
> > not change over time. VFSOC however, which uses the voltage fuel gauge
> > to determine the state of charge, always shows an accurate value.
> >
> > At least one max170xx driver, found in Asus' Z00D kernel [1], chooses
> > how to get the capacity based on if current sense is available or not.
> > Lets change the mainline driver to match the Asus Z00D driver's
> > behaviour and thereby fix so that correct state of charge values are
> > obtained on Galaxy S3.
> >
> > [1] https://github.com/LineageOS/android_kernel_asus_Z00D/blob/c7ab0e3ec5b5/drivers/power/max17042_battery.c#L1103-L1105
> >
> > Suggested-by: Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de>
> > Signed-off-by: Henrik Grimler <henrik@grimler.se>
> > ---
> > drivers/power/supply/max17042_battery.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
>
> After explanation and double-checking of driver this makes sense. The
> driver already uses VFSoc for alerts (MiscCFG register) if
> !enable_current_sense.
>
> Fixes: 359ab9f5b154 ("power_supply: Add MAX17042 Fuel Gauge Driver")
> Cc: <stable@vger.kernel.org>
>
> These could be added when applying but maybe Sebastian wants a v2 with it?
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
I can send a v2 with updated commit message to mention that we already
use VFSOC for the alert on this device, and sneak in a patch to fix a
typo in Iavg_empty parameter.
> Best regards,
> Krzysztof
Best regards,
Henrik Grimler
prev parent reply other threads:[~2021-09-28 19:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 20:07 [PATCH 0/1] power: supply: max17042_battery: use VFSOC for capacity when no rsns Henrik Grimler
2021-09-19 20:07 ` [PATCH 1/1] " Henrik Grimler
2021-09-24 11:45 ` Krzysztof Kozlowski
2021-09-27 19:05 ` Henrik Grimler
2021-09-28 9:18 ` Krzysztof Kozlowski
2021-09-28 18:32 ` Henrik Grimler
2021-09-28 9:22 ` Krzysztof Kozlowski
2021-09-28 19:18 ` Henrik Grimler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVNqlIIAJNil5MFL@grimlerstat.localdomain \
--to=henrik@grimler.se \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sre@kernel.org \
--cc=wolfgit@wiedmeyer.de \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).