From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: devicetree@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-pm@vger.kernel.org, sboyd@kernel.org, vireshk@kernel.org,
"Bartłomiej Żołnierkiewicz" <b.zolnierkie@samsung.com>,
roger.lu@mediatek.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
"Marek Szyprowski" <m.szyprowski@samsung.com>
Subject: Re: [PATCH v5 2/4] dt-bindings: arm: samsung: Update the CHIPID binding for ASV
Date: Thu, 17 Oct 2019 11:03:01 +0200 [thread overview]
Message-ID: <e5f441af-a21c-292b-b6ba-7e1e6550f091@samsung.com> (raw)
In-Reply-To: <CAJKOXPeagcSRUm2Qwwby=NHfWGdQ6KVZ2htb3UmnU2GfX+Ckcg@mail.gmail.com>
On 10/16/19 18:16, Krzysztof Kozlowski wrote:
>> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
>> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
>> @@ -9,17 +9,42 @@ title: Samsung Exynos SoC series Chipid driver
BTW, I think we should rename the above title to talk about IP block/device
rather than driver, e.g.
-SAMSUNG Exynos SoCs Chipid driver.
+SAMSUNG Exynos SoC series CHIPID subsystem
>> +# Custom select to avoid matching all nodes with 'syscon'
>> +select:
>> + properties:
>> + compatible:
>> + contains:
>> + const: samsung,exynos4210-chipid
>> + required:
>> + - compatible
>> +
>> properties:
>> compatible:
>> - items:
>> - - const: samsung,exynos4210-chipid
>> + allOf:
>
> I think it was my mistake to use allOf in other Exynos bindings. It
> should not be needed.
Indeed it seems to work well without allOf, I was wondering why we
needed the custom select above AND allOf.
next prev parent reply other threads:[~2019-10-17 9:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191016145806eucas1p2d522901fc79e1ca6e03f1bb516a81370@eucas1p2.samsung.com>
2019-10-16 14:57 ` [PATCH v5 0/4] Exynos Adaptive Supply Voltage support Sylwester Nawrocki
[not found] ` <CGME20191016145810eucas1p1b31400c9b2e7f30cdf6deeb4ccee2788@eucas1p1.samsung.com>
2019-10-16 14:57 ` [PATCH v5 1/4] PM / OPP: Support adjusting OPP voltages at runtime Sylwester Nawrocki
2019-10-17 6:42 ` Viresh Kumar
2019-10-21 11:23 ` Krzysztof Kozlowski
2019-10-22 2:23 ` Viresh Kumar
2019-10-22 18:43 ` Krzysztof Kozlowski
[not found] ` <CGME20191016145812eucas1p1a3cf3f44a2cff4c32a2270334630c4a2@eucas1p1.samsung.com>
2019-10-16 14:57 ` [PATCH v5 2/4] dt-bindings: arm: samsung: Update the CHIPID binding for ASV Sylwester Nawrocki
2019-10-16 16:16 ` Krzysztof Kozlowski
2019-10-17 9:03 ` Sylwester Nawrocki [this message]
[not found] ` <CGME20191016145813eucas1p1623db169f1ee93f88cb2c75090804747@eucas1p1.samsung.com>
2019-10-16 14:57 ` [PATCH v5 3/4] soc: samsung: Add Exynos Adaptive Supply Voltage driver Sylwester Nawrocki
2019-10-22 19:04 ` Krzysztof Kozlowski
2019-10-23 10:48 ` Sylwester Nawrocki
2019-10-23 11:20 ` Krzysztof Kozlowski
[not found] ` <CGME20191016145814eucas1p10d50d438abb850fd82f622122b223196@eucas1p1.samsung.com>
2019-10-16 14:57 ` [PATCH v5 4/4] ARM: EXYNOS: Enable exynos-asv driver for ARCH_EXYNOS Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5f441af-a21c-292b-b6ba-7e1e6550f091@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=roger.lu@mediatek.com \
--cc=sboyd@kernel.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).