From: Vinod Koul <vkoul@kernel.org>
To: cang@codeaurora.org
Cc: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
asutoshd@codeaurora.org, nguyenb@codeaurora.org,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-scsi@vger.kernel.org, kernel-team@android.com,
saravanak@google.com, Mark Salyzyn <salyzyn@google.com>,
Andy Gross <agross@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 2/7] scsi: ufs-qcom: Add reset control support for host controller
Date: Thu, 19 Dec 2019 19:51:45 +0530 [thread overview]
Message-ID: <20191219142145.GV2536@vkoul-mobl> (raw)
In-Reply-To: <983c21bb5ad2d38e11c074528d8898b9@codeaurora.org>
On 19-12-19, 15:12, cang@codeaurora.org wrote:
> On 2019-12-18 12:12, Vinod Koul wrote:
> > On 18-12-19, 02:44, cang@codeaurora.org wrote:
>
> Aside of the phy settings, your DT needs some modifications too,
> seems you copied most of them from sdm845.
> https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=3834a2e92229ef26d30de28acb698b2b23d3e397
>
> <--snip-->
> > + ufs_mem_phy: phy@1d87000 {
> > + compatible = "qcom,sm8150-qmp-ufs-phy";
> > + reg = <0 0x01d87000 0 0x18c>;
>
> The size 0x18c is wrong, in the code you are even accessing registers
> whose offsets are beyond 0x18c, see
>
> #define QSERDES_V4_COM_BIN_VCOCAL_CMP_CODE1_MODE0 0x1ac
> #define QSERDES_V4_COM_BIN_VCOCAL_CMP_CODE2_MODE0 0x1b0
> #define QSERDES_V4_COM_BIN_VCOCAL_CMP_CODE1_MODE1 0x1b4
> #define QSERDES_V4_COM_BIN_VCOCAL_HSCLK_SEL 0x1bc
> #define QSERDES_V4_COM_BIN_VCOCAL_CMP_CODE2_MODE1 0x1b8
>
> FYI, the total size of serdes registers is 0x1c0.
Yeah I will update it to 0x1c0
>
> <--snip-->
> > + ufs_mem_phy_lanes: lanes@1d87400 {
> > + reg = <0 0x01d87400 0 0x108>,
> > + <0 0x01d87600 0 0x1e0>,
> > + <0 0x01d87c00 0 0x1dc>,
>
> Same as above, see
>
> #define QPHY_V4_MULTI_LANE_CTRL1 0x1e0
>
> FYI, the total size of PCS registers is 0x200
>
> > + <0 0x01d87800 0 0x108>,
> > + <0 0x01d87a00 0 0x1e0>;
> > + #phy-cells = <0>;
> > + };
> <--snip-->
So I managed to fix it by configuring QPHY_SW_RESET in
qcom_qmp_phy_com_init() before invoking the configuration. That makes it
work for me. Will send patches shortly
--
~Vinod
next prev parent reply other threads:[~2019-12-19 14:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 6:09 [PATCH v5 0/7] UFS driver general fixes bundle 3 Can Guo
2019-11-15 6:09 ` [PATCH v5 1/7] scsi: ufs: Add device reset in link recovery path Can Guo
2019-11-15 6:25 ` Stanley Chu
2019-11-15 6:09 ` [PATCH v5 2/7] scsi: ufs-qcom: Add reset control support for host controller Can Guo
2019-11-15 10:08 ` Avri Altman
2019-12-16 19:04 ` Vinod Koul
2019-12-16 19:12 ` Jeffrey Hugo
2019-12-17 0:37 ` cang
2019-12-17 4:13 ` Vinod Koul
2019-12-17 7:10 ` cang
2019-12-17 9:24 ` Vinod Koul
2019-12-17 10:09 ` cang
2019-12-17 15:08 ` Vinod Koul
2019-12-17 16:00 ` Jeffrey Hugo
2019-12-17 18:44 ` cang
2019-12-18 4:12 ` Vinod Koul
2019-12-19 7:12 ` cang
2019-12-19 14:21 ` Vinod Koul [this message]
2019-12-19 14:25 ` Jeffrey Hugo
2019-12-19 14:52 ` Vinod Koul
2019-12-20 0:30 ` cang
2019-11-15 6:09 ` [PATCH v5 3/7] scsi: ufs: Fix up auto hibern8 enablement Can Guo
2019-11-15 6:35 ` Stanley Chu
2019-11-15 7:03 ` Can Guo
2019-11-15 7:18 ` Stanley Chu
2019-11-15 12:27 ` Can Guo
2019-11-15 13:46 ` Stanley Chu
2019-11-15 6:09 ` [PATCH v5 4/7] scsi: ufs: Fix register dump caused sleep in atomic context Can Guo
2019-11-15 6:09 ` [PATCH v5 5/7] scsi: ufs: Fix irq return code Can Guo
2019-11-15 6:09 ` [PATCH v5 6/7] scsi: ufs: Abort gating if clock on request is pending Can Guo
2019-11-15 6:09 ` [PATCH v5 7/7] scsi: ufs: Fix error handing during hibern8 enter Can Guo
2019-11-15 10:12 ` Avri Altman
2019-11-17 16:36 ` [EXT] " Bean Huo (beanhuo)
2019-11-19 4:28 ` [PATCH v5 0/7] UFS driver general fixes bundle 3 Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219142145.GV2536@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=cang@codeaurora.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=pedrom.sousa@synopsys.com \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).