From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
bvanassche@acm.org
Subject: [PATCH v2 0/5] scsi: target:
Date: Thu, 26 Mar 2020 23:15:00 +0100 [thread overview]
Message-ID: <20200326221505.5303-1-ddiss@suse.de> (raw)
These changes remove unnecessary heap allocations in the XCOPY
READ/WRITE dispatch loop.
Synthetic benchmarks on my laptop using the libiscsi iscsi-dd utility
(--xcopy --max 1 --blocks 65535 src=dst) against a target backed by an
8G zram (DEBUG_KMEMLEAK=y) iblock backstore (avg across four runs) show:
before: 5.30845G/s
after: 5.99056G/s (approx. +12.8%)
Changes since v1:
- drop RFC
- rework 3/5 and 5/5 following Christoph's feedback
Feedback appreciated.
Cheers, David
----------------------------------------------------------------
David Disseldorp (5):
scsi: target: use #def for xcopy descriptor len
scsi: target: drop xcopy DISK BLOCK LENGTH debug
scsi: target: avoid per-loop XCOPY buffer allocations
scsi: target: increase XCOPY I/O size
scsi: target: use the stack for XCOPY passthrough cmds
drivers/target/target_core_xcopy.c | 160 ++++++++++-------------------
drivers/target/target_core_xcopy.h | 9 +-
2 files changed, 55 insertions(+), 114 deletions(-)
next reply other threads:[~2020-03-26 22:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 22:15 David Disseldorp [this message]
2020-03-26 22:15 ` [PATCH v2 1/5] scsi: target: use #def for xcopy descriptor len David Disseldorp
2020-03-26 22:15 ` [PATCH v2 2/5] scsi: target: drop xcopy DISK BLOCK LENGTH debug David Disseldorp
2020-03-26 22:15 ` [PATCH v2 3/5] scsi: target: avoid per-loop XCOPY buffer allocations David Disseldorp
2020-03-27 9:24 ` Christoph Hellwig
2020-03-26 22:15 ` [PATCH v2 4/5] scsi: target: increase XCOPY I/O size David Disseldorp
2020-03-26 22:15 ` [PATCH v2 5/5] scsi: target: use the stack for XCOPY passthrough cmds David Disseldorp
2020-03-27 9:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326221505.5303-1-ddiss@suse.de \
--to=ddiss@suse.de \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).