From: David Disseldorp <ddiss@suse.de>
To: Douglas Gilbert <dgilbert@interlog.com>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
target-devel@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, martin.petersen@oracle.com,
jejb@linux.vnet.ibm.com, bostroesser@gmail.com,
bvanassche@acm.org, jgg@ziepe.ca
Subject: Re: [PATCH v6 3/4] scatterlist: add sgl_compare_sgl() function
Date: Tue, 19 Jan 2021 12:50:15 +0100 [thread overview]
Message-ID: <20210119125015.2f063af5@suse.de> (raw)
In-Reply-To: <d0b8312b-5dbf-6196-d962-40851c5cbbf7@interlog.com>
On Mon, 18 Jan 2021 20:04:20 -0500, Douglas Gilbert wrote:
> >> +bool sgl_compare_sgl(struct scatterlist *x_sgl, unsigned int x_nents, off_t x_skip,
> >> + struct scatterlist *y_sgl, unsigned int y_nents, off_t y_skip,
> >> + size_t n_bytes);
> >> +
> >> +bool sgl_compare_sgl_idx(struct scatterlist *x_sgl, unsigned int x_nents, off_t x_skip,
> >> + struct scatterlist *y_sgl, unsigned int y_nents, off_t y_skip,
> >> + size_t n_bytes, size_t *miscompare_idx);
> >
> >
> > This patch looks good and works fine as a replacement for
> > compare_and_write_do_cmp(). One minor suggestion would be to name it
> > sgl_equal() or similar, to perhaps better reflect the bool return and
> > avoid memcmp() confusion. Either way:
> > Reviewed-by: David Disseldorp <ddiss@suse.de>
>
> Thanks. NVMe calls the command that does this Compare and SCSI uses
> COMPARE AND WRITE (and VERIFY(BYTCHK=1) ) but "equal" is fine with me.
> There will be another patchset version (at least) so there is time
> to change.
>
> Do you want:
> - sgl_equal(...), or
> - sgl_equal_sgl(...) ?
I'd probably prefer the former as it's shorter, but I don't feel
strongly about it. The latter would make sense if you expect sgl compare
helpers for other buffer types.
Cheers, David
next prev parent reply other threads:[~2021-01-19 18:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 16:30 [PATCH v6 0/4] scatterlist: add new capabilities Douglas Gilbert
2021-01-18 16:30 ` [PATCH v6 1/4] sgl_alloc_order: remove 4 GiB limit, sgl_free() warning Douglas Gilbert
2021-01-18 18:28 ` Jason Gunthorpe
2021-01-18 20:08 ` Douglas Gilbert
2021-01-18 20:24 ` Jason Gunthorpe
2021-01-18 21:22 ` Bodo Stroesser
2021-01-18 23:48 ` Jason Gunthorpe
2021-01-19 1:27 ` Douglas Gilbert
2021-01-19 12:59 ` Jason Gunthorpe
2021-01-19 17:24 ` Bodo Stroesser
2021-01-19 18:03 ` Jason Gunthorpe
2021-01-19 18:08 ` Bodo Stroesser
2021-01-19 18:17 ` Jason Gunthorpe
2021-01-19 18:39 ` Bodo Stroesser
2021-01-18 20:46 ` Bodo Stroesser
2021-01-18 16:30 ` [PATCH v6 2/4] scatterlist: add sgl_copy_sgl() function Douglas Gilbert
2021-01-18 16:30 ` [PATCH v6 3/4] scatterlist: add sgl_compare_sgl() function Douglas Gilbert
2021-01-18 23:27 ` David Disseldorp
2021-01-19 1:04 ` Douglas Gilbert
2021-01-19 11:50 ` David Disseldorp [this message]
2021-01-18 16:30 ` [PATCH v6 4/4] scatterlist: add sgl_memset() Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119125015.2f063af5@suse.de \
--to=ddiss@suse.de \
--cc=bostroesser@gmail.com \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jgg@ziepe.ca \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).