From: Don Brace <don.brace@microchip.com>
To: <hch@infradead.org>, <martin.petersen@oracle.com>,
<jejb@linux.vnet.ibm.com>, <linux-scsi@vger.kernel.org>
Cc: <Kevin.Barnett@microchip.com>, <scott.teel@microchip.com>,
<Justin.Lindley@microchip.com>, <scott.benesh@microchip.com>,
<gerry.morong@microchip.com>, <mahesh.rajashekhara@microchip.com>,
<mike.mcgowen@microchip.com>, <murthy.bhat@microchip.com>,
<balsundar.p@microchip.com>, <joseph.szczypek@hpe.com>,
<jeff@canonical.com>, <POSWALD@suse.com>,
<john.p.donnelly@oracle.com>, <mwilck@suse.com>,
<pmenzel@molgen.mpg.de>, <linux-kernel@vger.kernel.org>
Subject: [smartpqi updates V3 PATCH 8/9] smartpqi: fix isr accessing uninitialized data
Date: Wed, 14 Jul 2021 13:28:46 -0500 [thread overview]
Message-ID: <20210714182847.50360-9-don.brace@microchip.com> (raw)
In-Reply-To: <20210714182847.50360-1-don.brace@microchip.com>
From: Mike McGowen <mike.mcgowen@microchip.com>
Correct driver's ISR accessing a data structure member
that has not been fully initialized during driver
initialization.
- The pqi queue groups can have uninitialized members
when an interrupt fires. This has not resulted in
any driver crashes. This was found during our own
internal testing. No bugs were ever filed.
Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com>
Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
Reviewed-by: Scott Teel <scott.teel@microchip.com>
Signed-off-by: Mike McGowen <mike.mcgowen@microchip.com>
Signed-off-by: Don Brace <don.brace@microchip.com>
---
drivers/scsi/smartpqi/smartpqi_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index f0e84354f782..ab1c9c483478 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -7760,11 +7760,11 @@ static int pqi_ctrl_init(struct pqi_ctrl_info *ctrl_info)
pqi_init_operational_queues(ctrl_info);
- rc = pqi_request_irqs(ctrl_info);
+ rc = pqi_create_queues(ctrl_info);
if (rc)
return rc;
- rc = pqi_create_queues(ctrl_info);
+ rc = pqi_request_irqs(ctrl_info);
if (rc)
return rc;
--
2.28.0.rc1.9.ge7ae437ac1
next prev parent reply other threads:[~2021-07-14 18:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 18:28 [smartpqi updates V3 PATCH 0/9] smartpqi updates Don Brace
2021-07-14 18:28 ` [smartpqi updates V3 PATCH 1/9] smartpqi: add pci ids for H3C P4408 controllers Don Brace
2021-07-14 18:28 ` [smartpqi updates V3 PATCH 2/9] smartpqi: update copyright notices Don Brace
2021-07-14 18:28 ` [smartpqi updates V3 PATCH 3/9] smartpqi: change driver module MACROS to microchip Don Brace
2021-07-14 18:28 ` [smartpqi updates V3 PATCH 4/9] smartpqi: change Kconfig menu entry " Don Brace
2021-07-14 18:28 ` [smartpqi updates V3 PATCH 5/9] smartpqi: add SCSI cmd info for resets Don Brace
2021-07-14 18:28 ` [smartpqi updates V3 PATCH 6/9] smartpqi: add PCI-ID for new ntcom controller Don Brace
2021-07-14 18:28 ` [smartpqi updates V3 PATCH 7/9] smartpqi: add PCI IDs for new ZTE controllers Don Brace
2021-07-14 18:28 ` Don Brace [this message]
2021-07-14 18:28 ` [smartpqi updates V3 PATCH 9/9] smartpqi: update version to 2.1.10-020 Don Brace
2021-07-19 2:45 ` [smartpqi updates V3 PATCH 0/9] smartpqi updates Martin K. Petersen
2021-07-19 18:10 ` Don.Brace
2021-07-24 2:13 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714182847.50360-9-don.brace@microchip.com \
--to=don.brace@microchip.com \
--cc=Justin.Lindley@microchip.com \
--cc=Kevin.Barnett@microchip.com \
--cc=POSWALD@suse.com \
--cc=balsundar.p@microchip.com \
--cc=gerry.morong@microchip.com \
--cc=hch@infradead.org \
--cc=jeff@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.p.donnelly@oracle.com \
--cc=joseph.szczypek@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mahesh.rajashekhara@microchip.com \
--cc=martin.petersen@oracle.com \
--cc=mike.mcgowen@microchip.com \
--cc=murthy.bhat@microchip.com \
--cc=mwilck@suse.com \
--cc=pmenzel@molgen.mpg.de \
--cc=scott.benesh@microchip.com \
--cc=scott.teel@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).