From: John Garry <john.garry@huawei.com>
To: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
"Bart Van Assche" <bvanassche@acm.org>
Cc: <satishkh@cisco.com>, <sebaddel@cisco.com>, <kartilak@cisco.com>,
<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] scsi: fnic: Stop setting scsi_cmnd.tag
Date: Mon, 16 Aug 2021 11:00:29 +0100 [thread overview]
Message-ID: <2e6dd74f-bd5a-22b8-f20b-d4b54fc4ade3@huawei.com> (raw)
In-Reply-To: <b6216e3f-5339-18e4-ca31-61c7968efbb1@suse.de>
On 14/08/2021 13:35, Hannes Reinecke wrote:
> On 8/14/21 9:39 AM, Christoph Hellwig wrote:
>> On Fri, Aug 13, 2021 at 08:17:45PM -0700, Bart Van Assche wrote:
>>> On 8/13/21 6:49 AM, John Garry wrote:
>>>> It is never read. Setting it and the request tag seems dodgy
>>>> anyway.
>>>
>>> This is done because there is code in the SCSI error handler that may
>>> allocate a SCSI command without allocating a tag. See also
>>> scsi_ioctl_reset().
Right, so we just get a loan of the tag of a real request. fnic driver
comment:
"Really should fix the midlayer to pass in a proper request for ioctls..."
>>
>> Yes. Hannes had a great series to stop passing the pointless scsi_cmnd
>> to the reset methods. Hannes, any chance you coul look into
>> resurrecting that?
>>
> Sure.
The latest iteration of that series - at v7 - still passed that fake
SCSI command to the reset method, and the reset method allocated the
internal command.
So will we change change scsi_ioctl_reset() to allocate an internal
command, rather than the LLDD?
Thanks,
John
next prev parent reply other threads:[~2021-08-16 10:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 13:49 [PATCH 0/3] Remove scsi_cmnd.tag John Garry
2021-08-13 13:49 ` [PATCH 1/3] scsi: wd719: Stop using scsi_cmnd.tag John Garry
2021-08-13 16:30 ` Hannes Reinecke
2021-08-14 3:11 ` Bart Van Assche
2021-08-13 13:49 ` [PATCH 2/3] scsi: fnic: Stop setting scsi_cmnd.tag John Garry
2021-08-13 16:31 ` Hannes Reinecke
2021-08-14 3:17 ` Bart Van Assche
2021-08-14 7:39 ` Christoph Hellwig
2021-08-14 12:35 ` Hannes Reinecke
2021-08-16 10:00 ` John Garry [this message]
2021-08-16 11:11 ` Hannes Reinecke
2021-08-13 13:49 ` [PATCH 3/3] scsi: Remove scsi_cmnd.tag John Garry
2021-08-13 16:31 ` Hannes Reinecke
2021-08-14 3:18 ` Bart Van Assche
2021-08-14 7:40 ` [PATCH 0/3] " Christoph Hellwig
2021-08-16 17:34 ` Martin K. Petersen
2021-08-18 18:08 ` John Garry
2021-08-18 18:46 ` Martin K. Petersen
2021-08-19 2:41 ` Bart Van Assche
2021-08-19 7:15 ` Hannes Reinecke
2021-08-19 7:27 ` John Garry
2021-08-19 7:50 ` Hannes Reinecke
2021-08-19 9:09 ` John Garry
2021-08-24 4:03 ` Martin K. Petersen
2021-08-24 7:54 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e6dd74f-bd5a-22b8-f20b-d4b54fc4ade3@huawei.com \
--to=john.garry@huawei.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).