From: Martin Wilck <mwilck@suse.com>
To: John Garry <john.garry@huawei.com>,
Donald Buczek <buczek@molgen.mpg.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ming Lei <ming.lei@redhat.com>
Cc: James Bottomley <jejb@linux.vnet.ibm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Hannes Reinecke <hare@suse.de>,
Don Brace <Don.Brace@microchip.com>,
Kevin Barnett <Kevin.Barnett@microchip.com>,
Paul Menzel <pmenzel@molgen.mpg.de>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] scsi: scsi_host_queue_ready: increase busy count early
Date: Fri, 22 Jan 2021 00:32:08 +0100 [thread overview]
Message-ID: <5724da4acbad312e8824ee097ca4d8eb831360e5.camel@suse.com> (raw)
In-Reply-To: <361d5a2f-fb8e-c400-2818-29aea435aff2@huawei.com>
On Thu, 2021-01-21 at 13:05 +0000, John Garry wrote:
> > >
>
> Confirmed my suspicions - it looks like the host is sent more
> commands
> than it can handle. We would need many disks to see this issue
> though,
> which you have.
>
> So for stable kernels, 6eb045e092ef is not in 5.4 . Next is 5.10, and
> I
> suppose it could be simply fixed by setting .host_tagset in scsi host
> template there.
If it's really just that, it should be easy enough to verify.
@Donald, you'd need to test with a 5.10 kernel, and after reproducing
the issue, add
.host_tagset = 1,
to the definition of pqi_driver_template in
drivers/scsi/smartpqi/smartpqi_init.c.
You don't need a patch to test that, I believe. Would you able to do
this test?
Regards,
Martin
next prev parent reply other threads:[~2021-01-21 23:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 18:45 [PATCH] scsi: scsi_host_queue_ready: increase busy count early mwilck
2021-01-20 20:26 ` John Garry
2021-01-21 12:01 ` Donald Buczek
2021-01-21 12:35 ` John Garry
2021-01-21 12:44 ` Donald Buczek
2021-01-21 13:05 ` John Garry
2021-01-21 23:32 ` Martin Wilck [this message]
2021-03-11 16:36 ` Donald Buczek
2021-02-01 22:44 ` Don.Brace
2021-02-02 20:04 ` Don.Brace
2021-02-02 20:48 ` Martin Wilck
2021-02-03 8:49 ` John Garry
2021-02-03 8:58 ` Paul Menzel
2021-02-03 15:30 ` Don.Brace
2021-02-03 15:56 ` Don.Brace
2021-02-03 18:25 ` John Garry
2021-02-03 19:01 ` Don.Brace
2021-02-22 14:23 ` Roger Willcocks
2021-02-23 8:57 ` John Garry
2021-02-23 14:06 ` Roger Willcocks
2021-02-23 16:17 ` John Garry
2021-03-01 14:51 ` Paul Menzel
2021-01-21 9:07 ` Donald Buczek
2021-01-21 10:05 ` Martin Wilck
2021-01-22 0:14 ` Martin Wilck
2021-01-22 3:23 ` Ming Lei
2021-01-22 14:05 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5724da4acbad312e8824ee097ca4d8eb831360e5.camel@suse.com \
--to=mwilck@suse.com \
--cc=Don.Brace@microchip.com \
--cc=Kevin.Barnett@microchip.com \
--cc=buczek@molgen.mpg.de \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).