From: Jinpu Wang <jinpu.wang@ionos.com>
To: Igor Pylypiv <ipylypiv@google.com>
Cc: Jack Wang <jinpu.wang@ionos.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Vishakha Channapattan <vishakhavc@google.com>,
Changyuan Lyu <changyuanl@google.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/4] scsi: pm80xx: Apply byte mask for phy id in mpi_phy_start_resp()
Date: Tue, 2 Nov 2021 08:04:34 +0100 [thread overview]
Message-ID: <CAMGffEkK4QqX93X7VKyqrNTOxtcBfHgSEV_+tjNgDSLxC95cMA@mail.gmail.com> (raw)
In-Reply-To: <20211101232825.2350233-2-ipylypiv@google.com>
On Tue, Nov 2, 2021 at 12:28 AM Igor Pylypiv <ipylypiv@google.com> wrote:
>
> Phy id is located in the least significant byte of the 4-byte field.
> mpi_phy_stop_resp() already applies such mask.
>
> Reviewed-by: Vishakha Channapattan <vishakhavc@google.com>
> Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
Thanks
> ---
> drivers/scsi/pm8001/pm80xx_hwi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index 6ffe17b849ae..4f887925c9d2 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -3481,7 +3481,7 @@ static int mpi_phy_start_resp(struct pm8001_hba_info *pm8001_ha, void *piomb)
> u32 status =
> le32_to_cpu(pPayload->status);
> u32 phy_id =
> - le32_to_cpu(pPayload->phyid);
> + le32_to_cpu(pPayload->phyid) & 0xFF;
> struct pm8001_phy *phy = &pm8001_ha->phy[phy_id];
>
> pm8001_dbg(pm8001_ha, INIT,
> --
> 2.33.1.1089.g2158813163f-goog
>
next prev parent reply other threads:[~2021-11-02 7:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 23:28 [PATCH 0/4] small pm80xx cleanups and fixes Igor Pylypiv
2021-11-01 23:28 ` [PATCH 1/4] scsi: pm80xx: Apply byte mask for phy id in mpi_phy_start_resp() Igor Pylypiv
2021-11-02 7:04 ` Jinpu Wang [this message]
2021-11-01 23:28 ` [PATCH 2/4] scsi: pm80xx: Do not check the address-of value for NULL Igor Pylypiv
2021-11-02 7:06 ` Jinpu Wang
2021-11-01 23:28 ` [PATCH 3/4] scsi: pm80xx: Update WARN_ON check in pm8001_mpi_build_cmd() Igor Pylypiv
2021-11-02 7:07 ` Jinpu Wang
2021-11-01 23:28 ` [PATCH 4/4] scsi: pm80xx: Use bitmap_zalloc() for tags bitmap allocation Igor Pylypiv
2021-11-02 7:08 ` Jinpu Wang
2021-11-19 2:50 ` [PATCH 0/4] small pm80xx cleanups and fixes Martin K. Petersen
2021-11-23 3:49 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMGffEkK4QqX93X7VKyqrNTOxtcBfHgSEV_+tjNgDSLxC95cMA@mail.gmail.com \
--to=jinpu.wang@ionos.com \
--cc=changyuanl@google.com \
--cc=ipylypiv@google.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=vishakhavc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).