From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Changheun Lee <nanich.lee@samsung.com>,
"arnd@arndb.de" <arnd@arndb.de>, "hch@lst.de" <hch@lst.de>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"jisoo2146.oh@samsung.com" <jisoo2146.oh@samsung.com>,
"junho89.kim@samsung.com" <junho89.kim@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"michael.christie@oracle.com" <michael.christie@oracle.com>,
"mj0123.lee@samsung.com" <mj0123.lee@samsung.com>,
"oneukum@suse.com" <oneukum@suse.com>,
"seunghwan.hyun@samsung.com" <seunghwan.hyun@samsung.com>,
"sookwan7.kim@samsung.com" <sookwan7.kim@samsung.com>,
"woosung2.lee@samsung.com" <woosung2.lee@samsung.com>,
"yt0928.kim@samsung.com" <yt0928.kim@samsung.com>
Subject: Re: [PATCH 1/1] scsi: sd: use max_xfer_blocks for set rw_max if max_xfer_blocks is available
Date: Fri, 22 Jan 2021 22:38:58 -0500 [thread overview]
Message-ID: <yq15z3o9vod.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <BL0PR04MB6514C248B950F5FDB77B96EAE7A00@BL0PR04MB6514.namprd04.prod.outlook.com> (Damien Le Moal's message of "Fri, 22 Jan 2021 07:44:00 +0000")
Damien,
>> How about set larger valid value between sdkp->max_xfer_blocks,
>> and sdkp->opt_xfer_blocks to rw_max?
>
> Again, if your device reports an opt_xfer_blocks value that is too
> small for its own good, that is a problem with this device.
Correct. It is very much intentional that we do not default to issuing
the largest commands supported by the physical hardware.
If the device is not reporting an optimal transfer size, and the block
layer default is too small, the solution is to adjust max_sectors_kb in
sysfs (by adding a udev rule, for instance).
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-01-23 3:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210113064521epcas1p32f0e65bc54d559b55db65bc5556103e8@epcas1p3.samsung.com>
2021-01-13 15:50 ` [PATCH 1/1] scsi: sd: use max_xfer_blocks for set rw_max if max_xfer_blocks is available Manjong Lee
[not found] ` <CGME20210120064450epcas1p1b00b7a040e0951a2da44abce916e1698@epcas1p1.samsung.com>
2021-01-20 8:00 ` Damien Le Moal
[not found] ` <CGME20210122072413epcas1p2d7bd97c9eae97b9b77d13e2c4a2f02f2@epcas1p2.samsung.com>
2021-01-22 7:08 ` Changheun Lee
2021-01-22 7:44 ` Damien Le Moal
2021-01-23 3:38 ` Martin K. Petersen [this message]
[not found] ` <CGME20210126041455epcas1p2c38ddc3bfe20bcf10217956b47096a33@epcas1p2.samsung.com>
2021-01-26 3:59 ` Changheun Lee
2021-01-27 3:50 ` Martin K. Petersen
[not found] ` <CGME20210127070438epcas1p417a8c9288df420b0af1ed9d185c87a22@epcas1p4.samsung.com>
2021-01-27 6:49 ` Changheun Lee
2021-01-20 15:49 ` Manjong Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq15z3o9vod.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=Damien.LeMoal@wdc.com \
--cc=arnd@arndb.de \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=jisoo2146.oh@samsung.com \
--cc=junho89.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mj0123.lee@samsung.com \
--cc=nanich.lee@samsung.com \
--cc=oneukum@suse.com \
--cc=seunghwan.hyun@samsung.com \
--cc=sookwan7.kim@samsung.com \
--cc=woosung2.lee@samsung.com \
--cc=yt0928.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).