From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: zhengbin <zhengbin13@huawei.com>,
bvanassche@acm.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
yi.zhang@huawei.com, yanaijie@huawei.com,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH v5 00/13] scsi: core: fix uninit-value access of variable sshdr
Date: Fri, 18 Oct 2019 09:43:33 -0400 [thread overview]
Message-ID: <yq1lftii2yi.fsf@oracle.com> (raw)
In-Reply-To: <f9c663fe-6359-fc7b-e9f5-cf173f6fafbe@suse.de> (Hannes Reinecke's message of "Fri, 18 Oct 2019 11:41:30 +0200")
Hannes,
> The one thing which I patently don't like is the ambivalence between
> DRIVER_SENSE and scsi_sense_valid(). What shall we do if only _one_
> of them is set? IE what would be the correct way of action if
> DRIVER_SENSE is not set, but we have a valid sense code? Or the other
> way around?
I agree, it's a mess.
(Sorry, zhengbin, you opened a can of worms. This is some of our oldest
and most arcane code in SCSI)
> But more important, from a quick glance not all drivers set the
> DRIVER_SENSE bit; so for things like hpsa or smartpqi the sense code is
> never evaluated after this patchset.
And yet we appear to have several code paths where sense evaluation is
contingent on DRIVER_SENSE. So no matter what, behavior might
change if we enforce consistent semantics. *sigh*
> I _really_ would prefer to ditch the 'DRIVER_SENSE' bit, and rely on
> scsi_sense_valid() only.
I would really like to get rid of DRIVER_* completely. Except for
DRIVER_SENSE, few are actually in use:
DRIVER_OK: 0
DRIVER_BUSY: 0
DRIVER_SOFT: 0
DRIVER_MEDIA: 0
DRIVER_ERROR: 6
DRIVER_INVALID: 4
DRIVER_TIMEOUT: 1
DRIVER_SENSE: 58
Johannes: Whatever happened to your efforts at cleaning all this up? Do
you have a patch series or a working tree we could use as starting
point?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-10-18 13:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 8:24 [PATCH v5 00/13] scsi: core: fix uninit-value access of variable sshdr zhengbin
2019-10-18 8:24 ` [PATCH v5 01/13] scsi: core: need to check the result of scsi_execute in scsi_report_opcode zhengbin
2019-10-18 8:24 ` [PATCH v5 02/13] scsi: core: need to check the result of scsi_execute in scsi_test_unit_ready zhengbin
2019-10-18 8:24 ` [PATCH v5 03/13] scsi: core: need to check the result of scsi_execute in scsi_report_lun_scan zhengbin
2019-10-18 8:24 ` [PATCH v5 04/13] scsi: sr: need to check the result of scsi_execute in sr_get_events zhengbin
2019-10-18 8:24 ` [PATCH v5 05/13] scsi: sr: need to check the result of scsi_execute in sr_do_ioctl zhengbin
2019-10-18 8:24 ` [PATCH v5 06/13] scsi: scsi_dh_emc: need to check the result of scsi_execute in send_trespass_cmd zhengbin
2019-10-18 8:24 ` [PATCH v5 07/13] scsi: scsi_dh_rdac: need to check the result of scsi_execute in send_mode_select zhengbin
2019-10-18 8:24 ` [PATCH v5 08/13] scsi: scsi_dh_hp_sw: need to check the result of scsi_execute in hp_sw_tur,hp_sw_start_stop zhengbin
2019-10-21 9:08 ` kbuild test robot
2019-10-18 8:24 ` [PATCH v5 09/13] scsi: scsi_dh_alua: need to check the result of scsi_execute in alua_rtpg,alua_stpg zhengbin
2019-10-18 8:24 ` [PATCH v5 10/13] scsi: scsi_transport_spi: need to check whether sshdr is valid in spi_execute zhengbin
2019-10-18 8:24 ` [PATCH v5 11/13] scsi: cxlflash: need to check whether sshdr is valid in read_cap16 zhengbin
2019-10-18 8:24 ` [PATCH v5 12/13] scsi: ufs: need to check whether sshdr is valid in ufshcd_set_dev_pwr_mode zhengbin
2019-10-18 8:24 ` [PATCH v5 13/13] scsi: ch: need to check whether sshdr is valid in ch_do_scsi zhengbin
2019-10-18 9:41 ` [PATCH v5 00/13] scsi: core: fix uninit-value access of variable sshdr Hannes Reinecke
2019-10-18 13:43 ` Martin K. Petersen [this message]
2019-10-18 14:05 ` Hannes Reinecke
2019-10-18 23:17 ` [RFC] scsi: Avoid sign extension when setting command result bytes, was " Finn Thain
2019-10-21 1:49 ` zhengbin (A)
2019-10-21 13:06 ` Hannes Reinecke
2019-10-22 1:59 ` zhengbin (A)
2019-10-23 6:51 ` zhengbin (A)
2019-10-21 6:57 ` Johannes Thumshirn
2019-10-18 12:33 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1lftii2yi.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=yanaijie@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).