From: Roberto Sassu <roberto.sassu@huawei.com>
To: lihuafei <lihuafei1@huawei.com>,
"zohar@linux.ibm.com" <zohar@linux.ibm.com>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "dmitry.kasatkin@gmail.com" <dmitry.kasatkin@gmail.com>,
"jmorris@namei.org" <jmorris@namei.org>,
"serge@hallyn.com" <serge@hallyn.com>,
yangjihong <yangjihong1@huawei.com>,
Zhangjinhao <zhangjinhao2@huawei.com>
Subject: RE: [PATCH] ima: Fix the error code for restoring the PCR value
Date: Wed, 24 Mar 2021 09:00:25 +0000 [thread overview]
Message-ID: <0764ed04a7e84546a8b31fc13b264c47@huawei.com> (raw)
In-Reply-To: <9df8d712-0e58-f95d-8f95-5feae2150b42@huawei.com>
> From: lihuafei
> Sent: Tuesday, March 23, 2021 2:41 PM
> ping. :-)
>
> On 2021/3/3 11:28, Li Huafei wrote:
> > In ima_restore_measurement_list(), hdr[HDR_PCR].data is pointing to a
> > buffer of type u8, which contains the dumped 32-bit pcr value.
> > Currently, only the least significant byte is used to restore the pcr
> > value. We should convert hdr[HDR_PCR].data to a pointer of type u32
> > before fetching the value to restore the correct pcr value.
> >
> > Fixes: 47fdee60b47f ("ima: use ima_parse_buf() to parse measurements
> headers")
> > Signed-off-by: Li Huafei <lihuafei1@huawei.com>
Hi Li Huafei
yes, correct. Thanks for the patch.
Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>
Roberto
HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Li Peng, Li Jian, Shi Yanli
> > ---
> > security/integrity/ima/ima_template.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/security/integrity/ima/ima_template.c
> b/security/integrity/ima/ima_template.c
> > index e22e510ae92d..4e081e650047 100644
> > --- a/security/integrity/ima/ima_template.c
> > +++ b/security/integrity/ima/ima_template.c
> > @@ -494,8 +494,8 @@ int ima_restore_measurement_list(loff_t size, void
> *buf)
> > }
> > }
> >
> > - entry->pcr = !ima_canonical_fmt ? *(hdr[HDR_PCR].data) :
> > - le32_to_cpu(*(hdr[HDR_PCR].data));
> > + entry->pcr = !ima_canonical_fmt ? *(u32
> *)(hdr[HDR_PCR].data) :
> > + le32_to_cpu(*(u32 *)(hdr[HDR_PCR].data));
> > ret = ima_restore_measurement_entry(entry);
> > if (ret < 0)
> > break;
> >
next prev parent reply other threads:[~2021-03-24 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 3:28 [PATCH] ima: Fix the error code for restoring the PCR value Li Huafei
2021-03-23 13:40 ` Li Huafei
2021-03-24 9:00 ` Roberto Sassu [this message]
2021-03-25 15:09 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0764ed04a7e84546a8b31fc13b264c47@huawei.com \
--to=roberto.sassu@huawei.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=jmorris@namei.org \
--cc=lihuafei1@huawei.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=yangjihong1@huawei.com \
--cc=zhangjinhao2@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).