From: Mimi Zohar <zohar@linux.ibm.com>
To: YueHaibing <yuehaibing@huawei.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] evm: remove set but not used variable 'xattr'
Date: Wed, 23 Jan 2019 13:38:55 -0500 [thread overview]
Message-ID: <1548268735.3971.6.camel@linux.ibm.com> (raw)
In-Reply-To: <9bdb64b6-501e-cd37-d4ab-a041ac25e738@huawei.com>
On Thu, 2019-01-17 at 16:21 +0800, YueHaibing wrote:
> ping...
>
> On 2018/12/15 18:06, YueHaibing wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > security/integrity/evm/evm_main.c: In function 'init_evm':
> > security/integrity/evm/evm_main.c:566:21: warning:
> > variable 'xattr' set but not used [-Wunused-but-set-variable]
> >
> > It never used since commit 21af76631476 ("EVM: turn evm_config_xattrnames
> > into a list")
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thank you. This patch is now queued in the next-integrity branch of
https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git
Mimi
> > ---
> > security/integrity/evm/evm_main.c | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/security/integrity/evm/evm_main.c b/security/integrity/evm/evm_main.c
> > index 5ecaa3d..b6d9f14 100644
> > --- a/security/integrity/evm/evm_main.c
> > +++ b/security/integrity/evm/evm_main.c
> > @@ -563,7 +563,6 @@ static int __init init_evm(void)
> > {
> > int error;
> > struct list_head *pos, *q;
> > - struct xattr_list *xattr;
> >
> > evm_init_config();
> >
> > @@ -580,11 +579,8 @@ static int __init init_evm(void)
> > error:
> > if (error != 0) {
> > if (!list_empty(&evm_config_xattrnames)) {
> > - list_for_each_safe(pos, q, &evm_config_xattrnames) {
> > - xattr = list_entry(pos, struct xattr_list,
> > - list);
> > + list_for_each_safe(pos, q, &evm_config_xattrnames)
> > list_del(pos);
> > - }
> > }
> > }
> >
> >
> >
> >
> > .
> >
>
prev parent reply other threads:[~2019-01-23 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 9:53 [PATCH -next] evm: CHECK-remove set but not used variable 'xattr' YueHaibing
2018-12-15 9:56 ` YueHaibing
2018-12-15 10:06 ` [PATCH -next] evm: remove " YueHaibing
2019-01-17 8:21 ` YueHaibing
2019-01-23 18:38 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548268735.3971.6.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).