From: Mimi Zohar <zohar@linux.ibm.com>
To: Roberto Sassu <roberto.sassu@huawei.com>, viro@zeniv.linux.org.uk
Cc: linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org, initramfs@vger.kernel.org,
linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, bug-cpio@gnu.org,
zohar@linux.vnet.ibm.com, silviu.vlasceanu@huawei.com,
dmitry.kasatkin@huawei.com, takondra@cisco.com,
kamensky@cisco.com, hpa@zytor.com, arnd@arndb.de,
rob@landley.net, james.w.mcmechan@gmail.com,
niveditas98@gmail.com
Subject: Re: [PATCH v4 2/3] initramfs: read metadata from special file METADATA!!!
Date: Mon, 01 Jul 2019 08:54:12 -0400 [thread overview]
Message-ID: <1561985652.4049.24.camel@linux.ibm.com> (raw)
In-Reply-To: <20190523121803.21638-3-roberto.sassu@huawei.com>
Hi Roberto,
> diff --git a/init/initramfs.c b/init/initramfs.c
> index 5de396a6aac0..862c03123de8 100644
> --- a/init/initramfs.c
> +++ b/init/initramfs.c
> +static int __init do_process_metadata(char *buf, int len, bool last)
> +{
Part of the problem in upstreaming CPIO xattr support has been the
difficulty in reading and understanding the initramfs code due to a
lack of comments. At least for any new code, let's add some comments
to simplify the review. In this case, understanding "last", before
reading the code, would help.
Mimi
> + int ret = 0;
> +
> + if (!metadata_buf) {
> + metadata_buf_ptr = metadata_buf = kmalloc(body_len, GFP_KERNEL);
> + if (!metadata_buf_ptr) {
> + ret = -ENOMEM;
> + goto out;
> + }
> +
> + metadata_len = body_len;
> + }
> +
> + if (metadata_buf_ptr + len > metadata_buf + metadata_len) {
> + ret = -EINVAL;
> + goto out;
> + }
> +
> + memcpy(metadata_buf_ptr, buf, len);
> + metadata_buf_ptr += len;
> +
> + if (last)
> + do_parse_metadata(previous_name_buf);
> +out:
> + if (ret < 0 || last) {
> + kfree(metadata_buf);
> + metadata_buf = NULL;
> + metadata = 0;
> + }
> +
> + return ret;
> +}
> +
> static int __init do_copy(void)
> {
> if (byte_count >= body_len) {
> if (xwrite(wfd, victim, body_len) != body_len)
> error("write error");
> + if (metadata)
> + do_process_metadata(victim, body_len, true);
> ksys_close(wfd);
> do_utime(vcollected, mtime);
> kfree(vcollected);
> @@ -458,6 +500,8 @@ static int __init do_copy(void)
> } else {
> if (xwrite(wfd, victim, byte_count) != byte_count)
> error("write error");
> + if (metadata)
> + do_process_metadata(victim, byte_count, false);
> body_len -= byte_count;
> eat(byte_count);
> return 1;
>
next prev parent reply other threads:[~2019-07-01 12:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 12:18 [PATCH v4 0/3] initramfs: add support for xattrs in the initial ram disk Roberto Sassu
2019-05-23 12:18 ` [PATCH v4 1/3] initramfs: add file metadata Roberto Sassu
2022-06-15 17:54 ` Eugeniu Rosca
2019-05-23 12:18 ` [PATCH v4 2/3] initramfs: read metadata from special file METADATA!!! Roberto Sassu
2019-07-01 12:54 ` Mimi Zohar [this message]
2019-05-23 12:18 ` [PATCH v4 3/3] gen_init_cpio: add support for file metadata Roberto Sassu
2019-06-30 15:27 ` Mimi Zohar
2022-06-16 14:47 ` Eugeniu Rosca
2022-06-16 15:16 ` Eugeniu Rosca
2022-06-30 15:06 ` Roberto Sassu
2022-06-30 20:38 ` Eugeniu Rosca
2019-06-03 9:31 ` [PATCH v4 0/3] initramfs: add support for xattrs in the initial ram disk Roberto Sassu
2019-06-03 18:32 ` Rob Landley
2019-06-26 8:15 ` Roberto Sassu
2019-06-30 15:39 ` Mimi Zohar
2019-07-01 13:42 ` Roberto Sassu
2019-07-01 14:31 ` Mimi Zohar
2019-07-15 16:54 ` Roberto Sassu
2019-07-24 15:34 ` Roberto Sassu
2022-06-09 10:26 ` Eugeniu Rosca
2022-06-09 11:05 ` Roberto Sassu
2022-06-10 15:33 ` Eugeniu Rosca
2022-06-10 15:38 ` Roberto Sassu
2022-06-15 9:27 ` Eugeniu Rosca
2022-07-18 16:36 ` Jim Baxter
2022-07-18 16:49 ` Roberto Sassu
2022-07-18 18:08 ` Jim Baxter
2022-07-19 6:55 ` Roberto Sassu
2022-07-19 11:50 ` Rob Landley
2022-07-19 12:26 ` Roberto Sassu
2022-07-19 14:14 ` Rob Landley
2022-07-20 11:52 ` Roberto Sassu
2022-07-29 10:37 ` Jim Baxter
2022-07-30 9:39 ` Rob Landley
2022-07-19 11:33 ` Rob Landley
2022-07-19 11:00 ` Rob Landley
2019-07-01 13:22 ` Mimi Zohar
2022-06-15 15:50 ` Alexander Lobakin
2022-06-15 16:03 ` Roberto Sassu
2022-06-16 13:24 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561985652.4049.24.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=bug-cpio@gnu.org \
--cc=dmitry.kasatkin@huawei.com \
--cc=hpa@zytor.com \
--cc=initramfs@vger.kernel.org \
--cc=james.w.mcmechan@gmail.com \
--cc=kamensky@cisco.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=niveditas98@gmail.com \
--cc=rob@landley.net \
--cc=roberto.sassu@huawei.com \
--cc=silviu.vlasceanu@huawei.com \
--cc=takondra@cisco.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).