From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
Peter Huewe <PeterHuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
Alexander Steffen <Alexander.Steffen@infineon.com>
Subject: Re: [PATCH v2 0/2] tpm: Unify send() callbacks
Date: Fri, 8 Feb 2019 18:23:16 +0200 [thread overview]
Message-ID: <20190208162316.GA25496@linux.intel.com> (raw)
In-Reply-To: <b0469b08-18fd-847b-0f0b-6223c732b346@linux.ibm.com>
On Fri, Feb 08, 2019 at 11:14:42AM -0500, Stefan Berger wrote:
> On 2/8/19 11:03 AM, Jarkko Sakkinen wrote:
> > A portion of send() callbacks have returned length, in many cases just
> > returning back what was given as an argument, and tpm_crb has returned 0 on
> > success. This patch set fixes and unifies the behaviour.
> >
> > v2:
> > The drivers tpm_nsc and tpm_infineon were forgotten. For this version I
> > checked both with find and command and from Kconfig that everything that is
> > supposed to be a driver directly interfacing with the TPM core, is included
> > (e.g. discluding tpm_tis_spi).
>
>
> :-( st33zp24/i2c.c ends up calling i2c_master_send, which returns number of
> bytes written:
>
> https://elixir.bootlin.com/linux/latest/source/include/linux/i2c.h#L108
And i2c.c is not a TPM driver so does it matter?
Then st33zp24_send() is the callback interfacing with the TPM core.
/Jarkko
prev parent reply other threads:[~2019-02-08 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 16:03 [PATCH v2 0/2] tpm: Unify send() callbacks Jarkko Sakkinen
2019-02-08 16:03 ` [PATCH v2 1/2] tpm: Unify the send callback behaviour Jarkko Sakkinen
2019-02-08 16:03 ` [PATCH v2 2/2] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete Jarkko Sakkinen
2019-02-08 16:14 ` [PATCH v2 0/2] tpm: Unify send() callbacks Stefan Berger
2019-02-08 16:23 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208162316.GA25496@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexander.Steffen@infineon.com \
--cc=PeterHuewe@gmx.de \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).