From: Steffen Klassert <steffen.klassert@secunet.com>
To: Antony Antony <antony.antony@secunet.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>,
<linux-security-module@vger.kernel.org>,
"Antony Antony" <antony@phenome.org>,
Stephan Mueller <smueller@chronox.de>
Subject: Re: [PATCH ipsec-next v5] xfrm: redact SA secret with lockdown confidentiality
Date: Mon, 23 Nov 2020 07:42:57 +0100 [thread overview]
Message-ID: <20201123064257.GF15658@gauss3.secunet.de> (raw)
In-Reply-To: <20201117164723.GA3868@moon.secunet.de>
On Tue, Nov 17, 2020 at 05:47:23PM +0100, Antony Antony wrote:
> redact XFRM SA secret in the netlink response to xfrm_get_sa()
> or dumpall sa.
> Enable lockdown, confidentiality mode, at boot or at run time.
>
> e.g. when enabled:
> cat /sys/kernel/security/lockdown
> none integrity [confidentiality]
>
> ip xfrm state
> src 172.16.1.200 dst 172.16.1.100
> proto esp spi 0x00000002 reqid 2 mode tunnel
> replay-window 0
> aead rfc4106(gcm(aes)) 0x0000000000000000000000000000000000000000 96
>
> note: the aead secret is redacted.
> Redacting secret is also a FIPS 140-2 requirement.
>
> v1->v2
> - add size checks before memset calls
> v2->v3
> - replace spaces with tabs for consistency
> v3->v4
> - use kernel lockdown instead of a /proc setting
> v4->v5
> - remove kconfig option
>
> Reviewed-by: Stephan Mueller <smueller@chronox.de>
> Signed-off-by: Antony Antony <antony.antony@secunet.com>
> ---
> include/linux/security.h | 1 +
> net/xfrm/xfrm_user.c | 74 ++++++++++++++++++++++++++++++++++++----
> security/security.c | 1 +
> 3 files changed, 69 insertions(+), 7 deletions(-)
I'm ok with this and I plan to apply it to ipsec-next if I do not see
objections from the LSM people.
prev parent reply other threads:[~2020-11-23 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200728154342.GA31835@moon.secunet.de>
2020-10-16 13:36 ` [PATCH] xfrm: redact SA secret with lockdown confidentiality Antony Antony
2020-10-31 10:49 ` Steffen Klassert
2020-11-17 16:46 ` Antony Antony
2020-11-17 16:47 ` [PATCH ipsec-next v5] " Antony Antony
2020-11-23 6:42 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123064257.GF15658@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=antony.antony@secunet.com \
--cc=antony@phenome.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).