From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD4B0C433E2 for ; Sat, 27 Jun 2020 04:37:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C50122089D for ; Sat, 27 Jun 2020 04:37:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725930AbgF0Ehf (ORCPT ); Sat, 27 Jun 2020 00:37:35 -0400 Received: from www262.sakura.ne.jp ([202.181.97.72]:62410 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbgF0Ehe (ORCPT ); Sat, 27 Jun 2020 00:37:34 -0400 Received: from fsav403.sakura.ne.jp (fsav403.sakura.ne.jp [133.242.250.102]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 05R4aXpv094511; Sat, 27 Jun 2020 13:36:33 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav403.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav403.sakura.ne.jp); Sat, 27 Jun 2020 13:36:33 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav403.sakura.ne.jp) Received: from [192.168.1.9] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 05R4aXkJ094506 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 27 Jun 2020 13:36:33 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: Re: [PATCH 05/14] umh: Separate the user mode driver and the user mode helper support To: "Eric W. Biederman" Cc: Linus Torvalds , David Miller , Greg Kroah-Hartman , Alexei Starovoitov , Kees Cook , Andrew Morton , Alexei Starovoitov , Al Viro , bpf , linux-fsdevel , Daniel Borkmann , Jakub Kicinski , Masahiro Yamada , Gary Lin , Bruno Meneguele , LSM List , Casey Schaufler References: <20200625095725.GA3303921@kroah.com> <778297d2-512a-8361-cf05-42d9379e6977@i-love.sakura.ne.jp> <20200625120725.GA3493334@kroah.com> <20200625.123437.2219826613137938086.davem@davemloft.net> <87pn9mgfc2.fsf_-_@x220.int.ebiederm.org> <87tuyyf0ln.fsf_-_@x220.int.ebiederm.org> <5ce4d340-096a-f468-6719-4c34a951511e@i-love.sakura.ne.jp> <87d05lbwt4.fsf@x220.int.ebiederm.org> <32604829-35f7-5263-aff1-27808500c1d1@i-love.sakura.ne.jp> <87k0zt87fd.fsf@x220.int.ebiederm.org> From: Tetsuo Handa Message-ID: <48747df2-3a04-01da-f854-3334672df7b2@i-love.sakura.ne.jp> Date: Sat, 27 Jun 2020 13:36:31 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <87k0zt87fd.fsf@x220.int.ebiederm.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On 2020/06/27 13:21, Eric W. Biederman wrote: > Tetsuo Handa writes: >> On 2020/06/27 1:45, Eric W. Biederman wrote: >>> Does this series by using the normal path through exec solve your >>> concerns with LSMs being able to identify these processes (both >>> individually and as class)?. >> >> I guess "yes" for pathname based LSMs. Though, TOMOYO wants to obtain both >> AT_SYMLINK_NOFOLLOW "struct path" and !AT_SYMLINK_NOFOLLOW "struct path" >> at do_open_execat() from do_execveat_common(). > > Is that a problem with the current do_execveat_common in general? In general. Since LSM does not receive parameters needed for obtaining AT_SYMLINK_NOFOLLOW "struct path" (and it is racy even if parameters were passed to LSM), I want to obtain both paths in one place. > > That does not sound like a problem in the user mode driver case as > there are no symlinks involved. Right.