From: Mimi Zohar <zohar@linux.ibm.com>
To: Roberto Sassu <roberto.sassu@huaweicloud.com>,
mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
dmitry.kasatkin@gmail.com, paul@paul-moore.com,
jmorris@namei.org, serge@hallyn.com,
stephen.smalley.work@gmail.com, eparis@parisplace.org,
casey@schaufler-ca.com
Cc: ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
linux-kernel@vger.kernel.org, keescook@chromium.org,
nicolas.bouchinet@clip-os.org,
Roberto Sassu <roberto.sassu@huawei.com>
Subject: Re: [PATCH v7 1/6] reiserfs: Switch to security_inode_init_security()
Date: Fri, 17 Feb 2023 14:47:35 -0500 [thread overview]
Message-ID: <53d2f07fd19f4ab74c66d4f4f07c62d163708ecd.camel@linux.ibm.com> (raw)
In-Reply-To: <20221201104125.919483-2-roberto.sassu@huaweicloud.com>
On Thu, 2022-12-01 at 11:41 +0100, Roberto Sassu wrote:
> From: Roberto Sassu <roberto.sassu@huawei.com>
>
> In preparation for removing security_old_inode_init_security(), switch to
> security_inode_init_security().
>
> Define the initxattrs callback reiserfs_initxattrs(), to populate the
> name/value/len triple in the reiserfs_security_handle() with the first
> xattr provided by LSMs. Make a copy of the xattr value, as
> security_inode_init_security() frees it.
>
> After the call to security_inode_init_security(), remove the check for
> returning -EOPNOTSUPP, as security_inode_init_security() changes it to
> zero.
>
> Multiple xattrs are currently not supported, as the
> reiserfs_security_handle structure is exported to user space. As a
> consequence, even if EVM is invoked, it will not provide an xattr (if it
> is not the first to set it, its xattr will be discarded; if it is the
> first, it does not have xattrs to calculate the HMAC on).
>
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> Reviewed-by: Casey Schaufler <casey@schaufler-ca.com>
Now that commit 572302af1258 ("reiserfs: Add missing calls to
reiserfs_security_free()") is upstreamed, please include a dependency
comment.
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
> ---
> fs/reiserfs/xattr_security.c | 23 ++++++++++++++++++-----
> 1 file changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/fs/reiserfs/xattr_security.c b/fs/reiserfs/xattr_security.c
> index 857a65b05726..0ba96757681d 100644
> --- a/fs/reiserfs/xattr_security.c
> +++ b/fs/reiserfs/xattr_security.c
> @@ -39,6 +39,22 @@ static bool security_list(struct dentry *dentry)
> return !IS_PRIVATE(d_inode(dentry));
> }
>
> +static int
> +reiserfs_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> + void *fs_info)
> +{
> + struct reiserfs_security_handle *sec = fs_info;
> +
> + sec->value = kmemdup(xattr_array->value, xattr_array->value_len,
> + GFP_KERNEL);
> + if (!sec->value)
> + return -ENOMEM;
> +
> + sec->name = xattr_array->name;
> + sec->length = xattr_array->value_len;
> + return 0;
> +}
> +
> /* Initializes the security context for a new inode and returns the number
> * of blocks needed for the transaction. If successful, reiserfs_security
> * must be released using reiserfs_security_free when the caller is done. */
> @@ -56,12 +72,9 @@ int reiserfs_security_init(struct inode *dir, struct inode *inode,
> if (IS_PRIVATE(dir))
> return 0;
>
> - error = security_old_inode_init_security(inode, dir, qstr, &sec->name,
> - &sec->value, &sec->length);
> + error = security_inode_init_security(inode, dir, qstr,
> + &reiserfs_initxattrs, sec);
> if (error) {
> - if (error == -EOPNOTSUPP)
> - error = 0;
> -
> sec->name = NULL;
> sec->value = NULL;
> sec->length = 0;
next prev parent reply other threads:[~2023-02-17 19:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 10:41 [PATCH v7 0/6] evm: Do HMAC of multiple per LSM xattrs for new inodes Roberto Sassu
2022-12-01 10:41 ` [PATCH v7 1/6] reiserfs: Switch to security_inode_init_security() Roberto Sassu
2023-02-17 19:47 ` Mimi Zohar [this message]
2022-12-01 10:41 ` [PATCH v7 2/6] ocfs2: " Roberto Sassu
2023-01-10 8:55 ` Roberto Sassu
2023-01-12 17:21 ` Paul Moore
2023-02-08 14:33 ` Roberto Sassu
2023-02-09 21:05 ` Paul Moore
2023-02-21 6:45 ` Joseph Qi
2023-02-21 7:51 ` Roberto Sassu
2023-02-17 19:51 ` Mimi Zohar
2023-02-17 21:30 ` Mimi Zohar
2023-02-20 9:27 ` Roberto Sassu
2023-02-20 11:08 ` Mimi Zohar
2023-02-20 12:20 ` Roberto Sassu
2023-02-20 12:40 ` Mimi Zohar
2023-02-20 8:34 ` Roberto Sassu
2022-12-01 10:41 ` [PATCH v7 3/6] security: Remove security_old_inode_init_security() Roberto Sassu
2023-02-19 19:41 ` Mimi Zohar
2022-12-01 10:41 ` [PATCH v7 4/6] security: Allow all LSMs to provide xattrs for inode_init_security hook Roberto Sassu
2023-02-20 12:43 ` Mimi Zohar
2022-12-01 10:41 ` [PATCH v7 5/6] evm: Align evm_inode_init_security() definition with LSM infrastructure Roberto Sassu
2023-02-19 19:41 ` Mimi Zohar
2022-12-01 10:41 ` [PATCH v7 6/6] evm: Support multiple LSMs providing an xattr Roberto Sassu
2023-02-19 19:42 ` Mimi Zohar
2023-02-20 9:49 ` Roberto Sassu
2023-02-20 10:56 ` Mimi Zohar
2023-01-12 17:15 ` [PATCH v7 0/6] evm: Do HMAC of multiple per LSM xattrs for new inodes Paul Moore
2023-01-13 10:35 ` Roberto Sassu
2023-03-08 22:16 ` Paul Moore
2023-03-09 7:53 ` Roberto Sassu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53d2f07fd19f4ab74c66d4f4f07c62d163708ecd.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=casey@schaufler-ca.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=eparis@parisplace.org \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=keescook@chromium.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=nicolas.bouchinet@clip-os.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=paul@paul-moore.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).