From: David Howells <dhowells@redhat.com>
To: trix@redhat.com
Cc: dhowells@redhat.com, jarkko.sakkinen@linux.intel.com,
jmorris@namei.org, serge@hallyn.com, denkenz@gmail.com,
marcel@holtmann.org, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KEYS: remove redundant memsets
Date: Wed, 22 Jul 2020 09:01:44 +0100 [thread overview]
Message-ID: <695450.1595404904@warthog.procyon.org.uk> (raw)
In-Reply-To: <20200721141516.20335-1-trix@redhat.com>
trix@redhat.com wrote:
> - if (copy_from_user(&uparams, _params, sizeof(uparams)) != 0)
> - return -EFAULT;
> -
> ret = keyctl_pkey_params_get(uparams.key_id, _info, params);
Erm... uparams is used on the very next statement after the copy_from_user().
David
prev parent reply other threads:[~2020-07-22 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 14:15 [PATCH] KEYS: remove redundant memsets trix
2020-07-22 6:42 ` kernel test robot
2020-07-22 8:01 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=695450.1595404904@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=denkenz@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=serge@hallyn.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).