From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AB82C433E1 for ; Fri, 26 Jun 2020 16:35:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBEC820781 for ; Fri, 26 Jun 2020 16:35:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726980AbgFZQf4 (ORCPT ); Fri, 26 Jun 2020 12:35:56 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:46180 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726933AbgFZQf4 (ORCPT ); Fri, 26 Jun 2020 12:35:56 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jorKP-0000ZI-IS; Fri, 26 Jun 2020 10:35:49 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jorKO-0008KB-5c; Fri, 26 Jun 2020 10:35:48 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Kees Cook Cc: Linus Torvalds , David Miller , Greg Kroah-Hartman , Tetsuo Handa , Alexei Starovoitov , Andrew Morton , Alexei Starovoitov , Al Viro , bpf , linux-fsdevel , Daniel Borkmann , Jakub Kicinski , Masahiro Yamada , Gary Lin , Bruno Meneguele , LSM List , Casey Schaufler References: <20200625095725.GA3303921@kroah.com> <778297d2-512a-8361-cf05-42d9379e6977@i-love.sakura.ne.jp> <20200625120725.GA3493334@kroah.com> <20200625.123437.2219826613137938086.davem@davemloft.net> <87pn9mgfc2.fsf_-_@x220.int.ebiederm.org> <87o8p6f0kw.fsf_-_@x220.int.ebiederm.org> <202006260836.FB867484@keescook> Date: Fri, 26 Jun 2020 11:31:20 -0500 In-Reply-To: <202006260836.FB867484@keescook> (Kees Cook's message of "Fri, 26 Jun 2020 08:37:05 -0700") Message-ID: <87bll5dc13.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1jorKO-0008KB-5c;;;mid=<87bll5dc13.fsf@x220.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/aEzzvuT3lhgyym3QCRnXX9VNZ0yqWApw= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 06/14] umd: For clarity rename umh_info umd_info X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: Kees Cook writes: > On Fri, Jun 26, 2020 at 07:55:43AM -0500, Eric W. Biederman wrote: >> This structure is only used for user mode drivers so change >> the prefix from umh to umd to make that clear. > > Should bpfilter_umh get renamed to bpfilter_umd at some point in this > series too? I think it would make a natural follow on, in a patches welcome sort of way. In this series I think it is important to draw a clear line between the user mode driver infrastructure and the more general user mode helper infrastructure. As it fundamentally makes a difference when you are skimming through the code trying to find the details you care about. But that line, which removes the maintenance burden from everyone else is where this series stops. I will be reposting shortly to fix the build issue I overlooked. Eric