From: Mimi Zohar <zohar@linux.ibm.com>
To: trix@redhat.com, dmitry.kasatkin@gmail.com, jmorris@namei.org,
serge@hallyn.com, jejb@linux.ibm.com,
jarkko.sakkinen@linux.intel.com, dhowells@redhat.com,
mortonm@chromium.org
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH] security: remove unneeded break
Date: Tue, 20 Oct 2020 16:45:49 -0400 [thread overview]
Message-ID: <9aeb4532d84e9d52444d67ff2d2e0e6c438e0a7d.camel@linux.ibm.com> (raw)
In-Reply-To: <20201019173653.527-1-trix@redhat.com>
On Mon, 2020-10-19 at 10:36 -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Recently "fall through" comments were added before any case statement
without a preceeding break. Have you made sure these changes won't be
flagged. Assuming you have,
Acked-by: Mimi Zohar <zohar@linux.ibm.com>
Mimi
next prev parent reply other threads:[~2020-10-20 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 17:36 [PATCH] security: remove unneeded break trix
2020-10-20 1:43 ` James Morris
2020-10-20 20:45 ` Mimi Zohar [this message]
2020-10-27 1:24 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9aeb4532d84e9d52444d67ff2d2e0e6c438e0a7d.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=dhowells@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jejb@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mortonm@chromium.org \
--cc=serge@hallyn.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).