linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anna Schumaker <anna.schumaker@netapp.com>
To: Paul Moore <paul@paul-moore.com>
Cc: Casey Schaufler <casey@schaufler-ca.com>,
	Olga Kornievskaia <olga.kornievskaia@gmail.com>,
	Trond Myklebust <trond.myklebust@hammerspace.com>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	Linux Security Module list 
	<linux-security-module@vger.kernel.org>,
	SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] [security] Add new hook to compare new mount to an existing mount
Date: Fri, 12 Mar 2021 10:45:42 -0500	[thread overview]
Message-ID: <CAFX2JfnT49o-CkaAE3=c0KW9SDS1U+scP0RD++nmWwyKoBDWkA@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhR=+uwN8U17JhYWKcXSc9=ExCrG4O9-y+DPJg6xZ=WoYA@mail.gmail.com>

On Thu, Mar 4, 2021 at 8:34 PM Paul Moore <paul@paul-moore.com> wrote:
>
> On Tue, Mar 2, 2021 at 10:53 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
> > On 3/2/2021 10:20 AM, Anna Schumaker wrote:
> > > Hi Casey,
> > >
> > > On Fri, Feb 26, 2021 at 10:40 PM Olga Kornievskaia
> > > <olga.kornievskaia@gmail.com> wrote:
> > >> From: Olga Kornievskaia <kolga@netapp.com>
> > >>
> > >> Add a new hook that takes an existing super block and a new mount
> > >> with new options and determines if new options confict with an
> > >> existing mount or not.
> > >>
> > >> A filesystem can use this new hook to determine if it can share
> > >> the an existing superblock with a new superblock for the new mount.
> > >>
> > >> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> > > Do you have any other thoughts on this patch? I'm also wondering how
> > > you want to handle sending it upstream.
> >
> > James Morris is the maintainer for the security sub-system,
> > so you'll want to send this through him. He will want you to
> > have an ACK from Paul Moore, who is the SELinux maintainer.
>
> In the past I've pulled patches such as this (new LSM hook, with only
> a SELinux implementation of the new hook) in via the selinux/next tree
> after the other LSMs have ACK'd the new hook.  This helps limit merge
> problems with other SELinux changes and allows us (the SELinux folks)
> to include it in the ongoing testing that we do during the -rcX
> releases.
>
> So Anna, if you or anyone else on the NFS side of the house want to
> add your ACKs/REVIEWs/etc. please do so as I don't like merging
> patches that cross subsystem boundaries without having all the
> associated ACKs.  Casey, James, and other LSM folks please do the
> same.

Sure:
Acked-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

Are you also going to take patch 3/3 that uses the new hook, or should
that go through the NFS tree? Patch 2/3 is a cleanup that can go
through the NFS tree.

Anna

>
> --
> paul moore
> www.paul-moore.com

  reply	other threads:[~2021-03-12 15:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19 22:22 [PATCH v3 1/3] [security] Add new hook to compare new mount to an existing mount Olga Kornievskaia
2021-02-19 22:22 ` [PATCH v3 2/3] [NFS] cleanup: remove unneeded null check in nfs_fill_super() Olga Kornievskaia
2021-03-22 19:00   ` Paul Moore
2021-02-19 22:22 ` [PATCH v3 3/3] NFSv4 account for selinux security context when deciding to share superblock Olga Kornievskaia
2021-03-22 19:04   ` Paul Moore
2021-02-25 17:53 ` [PATCH v3 1/3] [security] Add new hook to compare new mount to an existing mount Paul Moore
2021-02-25 18:03   ` Olga Kornievskaia
2021-02-25 18:22     ` Casey Schaufler
2021-02-25 19:30     ` Paul Moore
2021-02-27  3:37     ` [PATCH v4 " Olga Kornievskaia
2021-03-02 18:20       ` Anna Schumaker
2021-03-02 18:51         ` Casey Schaufler
2021-03-05  1:32           ` Paul Moore
2021-03-12 15:45             ` Anna Schumaker [this message]
2021-03-12 21:54               ` Paul Moore
2021-03-12 22:34                 ` Olga Kornievskaia
2021-03-15  1:43                   ` Paul Moore
2021-03-15 15:30                     ` Olga Kornievskaia
2021-03-15 16:15                       ` Paul Moore
2021-03-18 19:12                         ` Paul Moore
2021-03-18 19:21                           ` Casey Schaufler
2021-03-18 22:49                           ` James Morris
2021-03-18 22:59                             ` Olga Kornievskaia
2021-03-22 18:56                           ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFX2JfnT49o-CkaAE3=c0KW9SDS1U+scP0RD++nmWwyKoBDWkA@mail.gmail.com' \
    --to=anna.schumaker@netapp.com \
    --cc=casey@schaufler-ca.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=olga.kornievskaia@gmail.com \
    --cc=paul@paul-moore.com \
    --cc=selinux@vger.kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).