From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BB4CC433E1 for ; Tue, 19 May 2020 01:26:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C8F7207ED for ; Tue, 19 May 2020 01:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589851581; bh=LYpP6I6c1OWj6sWQN9uVoKs6OWExbkeTriflRzdrMPU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=aOBfUOoQFWeGd/8sP9zUeeZL2fRVEJGK7cLVe4fF4GyajAVYXXxRFD/i6RXXxuD0+ kntiExHrmg9qFVnqeGZvhthG6Llb3sLELrVlJMoS6YSrfSQhDwnHvrB31VEIGATHbn JV/+/yFmIW8tUl3dTqmk9gReIRDREoSd9hIo6n5s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727075AbgESB0U (ORCPT ); Mon, 18 May 2020 21:26:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726292AbgESB0T (ORCPT ); Mon, 18 May 2020 21:26:19 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF28BC061A0C for ; Mon, 18 May 2020 18:26:18 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id g4so11917783ljl.2 for ; Mon, 18 May 2020 18:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gs7dtmXWSFHCtE6SJeh0R5WhnxNGei8hq4y5MyR6ZaI=; b=g6f+fSpWv+q0J5qWk4vTM3N0tr/FDbfKxShNQ1hBeIUmG0ft9K/mDofqKrLzKT0ANb lccujvLSk+oHzhGNg8Ix24CcEu7WM3qPYVudg6Y7P+hECP8QDLjckalGWIXkWioVLqav 8RZdGRZ+c6ZskkaTAd9COiMlvaDxFA8w4xaaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gs7dtmXWSFHCtE6SJeh0R5WhnxNGei8hq4y5MyR6ZaI=; b=kz7/TrCOs/W1cpXkHGx3HkUNBt+VsMEVad0wVJ6XbtDr4QwqDvGS5IU02ukzL31dqx w/i62xRJEHSLW+tEJGE0u7QvafDE/iUhcwtm+4OmLz4l7dLbpQi2UbuQb6qh9Zlj1yel O367NG/m0vPYcAe2fOxiTNAs7Ax27iGcPkPCRHPvzwmZvG/zAekxxSX1XSsFVGoyDO8s Rq1GlXmOx6Ao9O2xT8FZeovZyxve1icrCYqMDS5LssZjrA7qvBr6obO+pWzqS7tiB0bL qSin9Yukw3qnXH3MBwafEqQKkCm8OqmEQvNeLs0uNqQN19mKdTLCq9OquqGuNDWF/70d E+5w== X-Gm-Message-State: AOAM532QSKyrOG3noy6wmcDj9uIKfHgU07y+LtM+r6kPf5nr8+4mo0Cv 4NYmxGEtDBOXfVjoLshy7Su2EJotP+c= X-Google-Smtp-Source: ABdhPJys26BHVsMOhPb+vkBtpl3SM2ZJUdGl13gKiuWgkLG35uBOyMm5iVQMrFRL+Z8VTHmXdM8qLQ== X-Received: by 2002:a2e:b53b:: with SMTP id z27mr12011036ljm.114.1589851576336; Mon, 18 May 2020 18:26:16 -0700 (PDT) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com. [209.85.208.180]) by smtp.gmail.com with ESMTPSA id j2sm7828193lfb.78.2020.05.18.18.26.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2020 18:26:15 -0700 (PDT) Received: by mail-lj1-f180.google.com with SMTP id l19so11926654lje.10 for ; Mon, 18 May 2020 18:26:14 -0700 (PDT) X-Received: by 2002:a2e:9641:: with SMTP id z1mr12188170ljh.201.1589851574208; Mon, 18 May 2020 18:26:14 -0700 (PDT) MIME-Version: 1.0 References: <87h7wujhmz.fsf@x220.int.ebiederm.org> <87sgga6ze4.fsf@x220.int.ebiederm.org> <87v9l4zyla.fsf_-_@x220.int.ebiederm.org> <877dx822er.fsf_-_@x220.int.ebiederm.org> In-Reply-To: <877dx822er.fsf_-_@x220.int.ebiederm.org> From: Linus Torvalds Date: Mon, 18 May 2020 18:25:58 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/8] exec: Control flow simplifications To: "Eric W. Biederman" Cc: Linux Kernel Mailing List , Oleg Nesterov , Jann Horn , Kees Cook , Greg Ungerer , Rob Landley , Bernd Edlinger , linux-fsdevel , Al Viro , Alexey Dobriyan , Andrew Morton , Casey Schaufler , LSM List , James Morris , "Serge E. Hallyn" , Andy Lutomirski Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Mon, May 18, 2020 at 5:32 PM Eric W. Biederman wrote: > > It is hard to follow the control flow in exec.c as the code has evolved over > time and something that used to work one way now works another. This set of > changes attempts to address the worst of that, to remove unnecessary work > and to make the code a little easier to follow. It is indeed hard to follow, and maybe I missed something, but from what I can tell, your series looks all sane. It certainly seems to make things much more straightforward. Of course, exactly _because_ it's such a messy area, maybe it introduces something odd, but all the patches look relatively straightforward. And you remove more lines of code than you add, which is always nice to see. So ack from me. Oleg? Jann? Anybody? Do you see anything strange that I missed? Linus