From: Roberto Sassu <roberto.sassu@huawei.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, <jgg@ziepe.ca>
Cc: <linux-integrity@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-security-module@vger.kernel.org>, <zohar@linux.ibm.com>,
<stable@vger.kernel.org>,
Silviu Vlasceanu <Silviu.Vlasceanu@huawei.com>
Subject: Re: [PATCH v2] tpm/st33zp24: Fix the name collisions in tpm_st33zp24_spi and tpm_i2c_infineon
Date: Tue, 5 Feb 2019 09:08:33 +0100 [thread overview]
Message-ID: <a6a9e68d-ff0a-c33d-50ce-5d18939c1ab3@huawei.com> (raw)
In-Reply-To: <20190204234047.GA15685@linux.intel.com>
On 2/5/2019 12:40 AM, Jarkko Sakkinen wrote:
> On Tue, Feb 05, 2019 at 01:31:17AM +0200, Jarkko Sakkinen wrote:
>> On Mon, Feb 04, 2019 at 02:49:54PM +0100, Roberto Sassu wrote:
>>> On 2/4/2019 2:37 PM, Jarkko Sakkinen wrote:
>>>> Rename TPM_BUFSIZE defined in drivers/char/tpm/st33zp24/st33zp24.h to
>>>> ST33ZP24_BUFSIZE.
>>>>
>>>> Rename TPM_BUFSIZE defined in drivers/char/tpm/tpm_i2c_infineon.c to
>>>> TPM_I2C_INFINEON_BUFSIZE.
>>>
>>> Please also add a prefix to TPM_RETRY in tpm_i2c_nuvoton.c.
>>
>> Thanks, can do.
>
> TPM_RETRY defined in
>
> 32d33b29ba07 ("TPM: Retry SaveState command in suspend path")
>
> has nothing to do with time. I'll also remove the comment about 5
> seconds.
I'll do the same for patch 4/6.
Roberto
> The definitions for TPM_RETRY seem fairly arbitrary. Jason, could
> tpm_i2c_nuvoton also use the same constant as tpm_tis_spi and TPM 1.2
> suspend, try max 50 times instead of five?
>
> /Jarkko
>
--
HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Bo PENG, Jian LI, Yanli SHI
next prev parent reply other threads:[~2019-02-05 8:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 13:37 [PATCH v2] tpm/st33zp24: Fix the name collisions in tpm_st33zp24_spi and tpm_i2c_infineon Jarkko Sakkinen
2019-02-04 13:49 ` Roberto Sassu
2019-02-04 23:31 ` Jarkko Sakkinen
2019-02-04 23:40 ` Jarkko Sakkinen
2019-02-05 8:08 ` Roberto Sassu [this message]
2019-02-05 8:36 ` Jarkko Sakkinen
2019-02-05 7:42 ` kbuild test robot
2019-02-05 8:10 ` kbuild test robot
2019-02-05 19:40 ` James Bottomley
2019-02-05 20:59 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6a9e68d-ff0a-c33d-50ce-5d18939c1ab3@huawei.com \
--to=roberto.sassu@huawei.com \
--cc=Silviu.Vlasceanu@huawei.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).