On Tue, 13 Aug 2019, Matthew Garrett wrote: > Fixups for the lockdown patchset. Potentially makes more sense to merge > these into the relevant original patches rather than keeping them > separate, but sending them for review. Which kernel version are these against? kernel/kexec_file.c: In function ‘kimage_validate_signature’: kernel/kexec_file.c:220:4: error: label ‘out’ used but not defined 220 | goto out; | ^~~~ kernel/kexec_file.c: In function ‘kimage_file_prepare_segments’: kernel/kexec_file.c:295:3: error: implicit declaration of function ‘ima_kexec_cmdline’ [-Werror=implicit-function-declaration] 295 | ima_kexec_cmdline(image->cmdline_buf, | ^~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors My next-lockdown branch is based on v5.2. -- James Morris