From: James Morris <jmorris@namei.org>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: paul@paul-moore.com, keescook@chromium.org,
casey@schaufler-ca.com, selinux@vger.kernel.org,
linux-security-module@vger.kernel.org, dhowells@redhat.com
Subject: Re: [PATCH] selinux: fix residual uses of current_security() for the SELinux blob
Date: Thu, 5 Sep 2019 05:35:49 +1000 (AEST) [thread overview]
Message-ID: <alpine.LRH.2.21.1909050535360.10775@namei.org> (raw)
In-Reply-To: <20190904143248.7003-1-sds@tycho.nsa.gov>
On Wed, 4 Sep 2019, Stephen Smalley wrote:
> We need to use selinux_cred() to fetch the SELinux cred blob instead
> of directly using current->security or current_security(). There
> were a couple of lingering uses of current_security() in the SELinux code
> that were apparently missed during the earlier conversions. IIUC, this
> would only manifest as a bug if multiple security modules including
> SELinux are enabled and SELinux is not first in the lsm order. After
> this change, there appear to be no other users of current_security()
> in-tree; perhaps we should remove it altogether.
>
> Fixes: bbd3662a8348 ("Infrastructure management of the cred security blob")
> Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
Reviewed-by: James Morris <jamorris@linux.microsoft.com>
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2019-09-04 19:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 14:32 [PATCH] selinux: fix residual uses of current_security() for the SELinux blob Stephen Smalley
2019-09-04 15:16 ` Casey Schaufler
2019-09-04 15:31 ` Stephen Smalley
2019-09-04 16:46 ` John Johansen
2019-09-04 19:35 ` James Morris [this message]
2019-09-04 22:50 ` Paul Moore
2019-09-05 20:01 ` Stephen Smalley
2019-09-05 20:55 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1909050535360.10775@namei.org \
--to=jmorris@namei.org \
--cc=casey@schaufler-ca.com \
--cc=dhowells@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).