From: James Morris <jmorris@namei.org>
To: Micah Morton <mortonm@chromium.org>
Cc: linux-security-module@vger.kernel.org, keescook@chromium.org,
casey@schaufler-ca.com, paul@paul-moore.com,
stephen.smalley.work@gmail.com, serge@hallyn.com,
Thomas Cedeno <thomascedeno@google.com>
Subject: Re: [PATCH 1/2] LSM: Signal to SafeSetID when in set*gid syscall
Date: Tue, 28 Jul 2020 04:44:18 +1000 (AEST) [thread overview]
Message-ID: <alpine.LRH.2.21.2007280444060.18670@namei.org> (raw)
In-Reply-To: <20200720181156.1461461-1-mortonm@chromium.org>
On Mon, 20 Jul 2020, Micah Morton wrote:
> From: Thomas Cedeno <thomascedeno@google.com>
>
> For SafeSetID to properly gate set*gid() calls, it needs to know whether
> ns_capable() is being called from within a sys_set*gid() function or is
> being called from elsewhere in the kernel. This allows SafeSetID to deny
> CAP_SETGID to restricted groups when they are attempting to use the
> capability for code paths other than updating GIDs (e.g. setting up
> userns GID mappings). This is the identical approach to what is
> currently done for CAP_SETUID.
>
> Signed-off-by: Thomas Cedeno <thomascedeno@google.com>
> Signed-off-by: Micah Morton <mortonm@chromium.org>
Acked-by: James Morris <jamorris@linux.microsoft.com>
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2020-07-27 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 18:11 [PATCH 1/2] LSM: Signal to SafeSetID when in set*gid syscall Micah Morton
2020-07-21 2:11 ` Serge E. Hallyn
2020-07-27 18:44 ` James Morris [this message]
2020-08-04 21:13 ` [PATCH v2 1/2] LSM: Signal to SafeSetID when setting group IDs Micah Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.2007280444060.18670@namei.org \
--to=jmorris@namei.org \
--cc=casey@schaufler-ca.com \
--cc=keescook@chromium.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mortonm@chromium.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
--cc=thomascedeno@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).