From: Casey Schaufler <casey@schaufler-ca.com>
To: Paul Moore <paul@paul-moore.com>
Cc: Steve Grubb <sgrubb@redhat.com>,
Richard Guy Briggs <rgb@redhat.com>,
"linux-audit@redhat.com" <linux-audit@redhat.com>,
Linux Security Module list
<linux-security-module@vger.kernel.org>,
casey@schaufler-ca.com
Subject: Re: Preferred subj= with multiple LSMs
Date: Wed, 17 Jul 2019 08:49:15 -0700 [thread overview]
Message-ID: <e9cf875a-0d0f-a56f-71dd-c22c67bdcc2d@schaufler-ca.com> (raw)
In-Reply-To: <CAHC9VhQ9MSh5zCkhMja4r9j0RT952LwKSaG5dR-BqXzXrtEAUw@mail.gmail.com>
On 7/17/2019 5:14 AM, Paul Moore wrote:
> On Tue, Jul 16, 2019 at 7:47 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
>> On 7/16/2019 4:13 PM, Paul Moore wrote:
>>> On Tue, Jul 16, 2019 at 6:18 PM Casey Schaufler <casey@schaufler-ca.com> wrote:
>>>> It sounds as if some variant of the Hideous format:
>>>>
>>>> subj=selinux='a:b:c:d',apparmor='z'
>>>> subj=selinux/a:b:c:d/apparmor/z
>>>> subj=(selinux)a:b:c:d/(apparmor)z
>>>>
>>>> would meet Steve's searchability requirements, but with significant
>>>> parsing performance penalties.
>>> I think "hideous format" sums it up nicely. Whatever we choose here
>>> we are likely going to be stuck with for some time and I'm near to
>>> 100% that multiplexing the labels onto a single field is going to be a
>>> disaster.
>> If the requirement is that subj= be searchable I don't see much of
>> an alternative to a Hideous format. If we can get past that, and say
>> that all subj_* have to be searchable we can avoid that set of issues.
>> Instead of:
>>
>> s = strstr(source, "subj=")
>> search_after_subj(s, ...);
> This example does a lot of hand waving in search_after_subj(...)
> regarding parsing the multiplexed LSM label. Unless we restrict the
> LSM label formats (which seems both wrong, and too late IMHO)
I don't think it's too late, and I think it would be healthy
to restrict LSM "contexts" to character sets that make command
line specification possible. Embedded newlines? Ewwww.
> we have
> a parsing nightmare; can you write a safe multiplexed LSM label parser
> without knowledge of each LSM label format? Can you do that for each
> LSM without knowing their loaded policy? What happens when the policy
> and/or label format changes? What happens in a few years when another
> LSM is added to the kernel?
I was intentionally hand-wavy because of those very issues.
Steve says that parsing is limited to "strstr()", so looking for
":s7:" in the subject should work just as well with a Hideous
format as it does today, with the exception of false positives
where LSMs have label string overlaps.
Where is the need to use a module specific label parser coming
from? Does the audit code parse SELinux contexts now?
>> we have
>>
>> s = source
>> for (i = 0; i < lsm_slots ; i++) {
>> s = strstr(s, "subj_")
>> if (!s)
>> break;
>> s = search_after_subj_(s, lsm_slot_name[i], ...)
> The hand waving here in search_after_subj_(...) is much less;
> essentially you just match "subj_X" and then you can take the field
> value as the LSM's label without having to know the format, the policy
> loaded, etc. It is both safer and doesn't require knowledge of the
> LSMs (the LSM "name" can be specified as a parameter to the search
> tool).
You can do that with the Hideous format as well. I wouldn't
say which would be easier without delving into the audit user
space.
>> There's enough ugly to go around either way.
>> And I'm not partial to either approach, but do would very
>> much like to get the code done so I can get on to the next
>> set of amazing challenges.
>>
>> Oh, and I don't want to pick on subj= as obj= has the exact same issues.
> Yes, I stopped talking about both subj and obj some time ago in this
> thread because I figure we can use the same approach for both.
>
next prev parent reply other threads:[~2019-07-17 15:49 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 16:33 Preferred subj= with multiple LSMs Casey Schaufler
[not found] ` <c46932ec-e38e-ba15-7ceb-70e0fe0ef5dc@schaufler-ca.com>
2019-07-13 15:08 ` Steve Grubb
2019-07-15 19:04 ` Richard Guy Briggs
[not found] ` <1979804.kRvuSoDnao@x2>
[not found] ` <2802ddee-b621-c2eb-9ff3-ea15c4f19d0c@schaufler-ca.com>
[not found] ` <3577098.oGDFHdoSSQ@x2>
2019-07-16 17:16 ` Casey Schaufler
[not found] ` <CAHC9VhSELVZN8feH56zsANqoHu16mPMD04Ww60W=r6tWs+8WnQ@mail.gmail.com>
2019-07-16 17:29 ` Casey Schaufler
2019-07-16 17:43 ` Paul Moore
2019-07-16 17:58 ` Casey Schaufler
2019-07-16 18:06 ` Steve Grubb
2019-07-16 18:41 ` Casey Schaufler
2019-07-16 21:25 ` Paul Moore
2019-07-16 21:46 ` Steve Grubb
2019-07-16 22:18 ` Casey Schaufler
2019-07-16 23:13 ` Paul Moore
2019-07-16 23:47 ` Casey Schaufler
2019-07-17 12:14 ` Paul Moore
2019-07-17 15:49 ` Casey Schaufler [this message]
2019-07-17 16:23 ` Paul Moore
2019-07-17 23:02 ` Casey Schaufler
2019-07-18 13:10 ` Simon McVittie
2019-07-18 16:13 ` Casey Schaufler
2019-07-19 12:15 ` Simon McVittie
2019-07-19 16:29 ` Casey Schaufler
2019-07-19 18:47 ` Simon McVittie
2019-07-19 20:02 ` Dbus and multiple LSMs (was Preferred subj= with multiple LSMs) Casey Schaufler
2019-07-22 11:36 ` Simon McVittie
2019-07-22 16:04 ` Casey Schaufler
2019-07-19 21:21 ` Preferred subj= with multiple LSMs Paul Moore
2019-07-22 20:50 ` James Morris
2019-07-22 22:01 ` Casey Schaufler
2019-07-22 22:30 ` Paul Moore
2019-07-23 0:11 ` Casey Schaufler
2019-07-23 14:06 ` Simon McVittie
2019-07-23 17:32 ` Casey Schaufler
2019-07-23 21:46 ` James Morris
2019-07-16 23:09 ` Paul Moore
2019-07-17 4:36 ` James Morris
2019-07-17 12:23 ` Paul Moore
2019-07-18 15:01 ` William Roberts
2019-07-18 18:48 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9cf875a-0d0f-a56f-71dd-c22c67bdcc2d@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=linux-audit@redhat.com \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).