From: Matthias Brugger <matthias.bgg@gmail.com>
To: Frank Wunderlich <frank-w@public-files.de>,
linux-mediatek@lists.infradead.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250-mtk: Use platform_get_irq_optional() for optional irq
Date: Sun, 10 Nov 2019 21:23:24 +0100 [thread overview]
Message-ID: <1e18621e-fa29-eae8-8720-45d6f75caf7c@gmail.com> (raw)
In-Reply-To: <20191027062117.20389-1-frank-w@public-files.de>
On 27/10/2019 07:21, Frank Wunderlich wrote:
> As platform_get_irq() now prints an error when the interrupt does not
> exist, this warnings are printed on bananapi-r2:
>
> [ 4.935780] mt6577-uart 11004000.serial: IRQ index 1 not found
> [ 4.962589] 11002000.serial: ttyS1 at MMIO 0x11002000 (irq = 202, base_baud = 1625000) is a ST16650V2
> [ 4.972127] mt6577-uart 11002000.serial: IRQ index 1 not found
> [ 4.998927] 11003000.serial: ttyS2 at MMIO 0x11003000 (irq = 203, base_baud = 1625000) is a ST16650V2
> [ 5.008474] mt6577-uart 11003000.serial: IRQ index 1 not found
>
> Fix this by calling platform_get_irq_optional() instead.
>
> now it looks like this:
>
> [ 4.872751] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled
>
> Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> changes since v1:
> https://patchwork.kernel.org/patch/11213813/
> change from platform_irq_count to platform_get_irq_optional
> ---
> drivers/tty/serial/8250/8250_mtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
> index b411ba4eb5e9..4d067f515f74 100644
> --- a/drivers/tty/serial/8250/8250_mtk.c
> +++ b/drivers/tty/serial/8250/8250_mtk.c
> @@ -544,7 +544,7 @@ static int mtk8250_probe(struct platform_device *pdev)
> pm_runtime_set_active(&pdev->dev);
> pm_runtime_enable(&pdev->dev);
>
> - data->rx_wakeup_irq = platform_get_irq(pdev, 1);
> + data->rx_wakeup_irq = platform_get_irq_optional(pdev, 1);
>
> return 0;
> }
>
prev parent reply other threads:[~2019-11-10 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 6:21 [PATCH] serial: 8250-mtk: Use platform_get_irq_optional() for optional irq Frank Wunderlich
2019-11-10 20:23 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e18621e-fa29-eae8-8720-45d6f75caf7c@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=frank-w@public-files.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).