From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: George Hilliard <ghilliard@kopismobile.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel@pengutronix.de, devicetree@vger.kernel.org,
NXP Linux Team <linux-imx@nxp.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 2/2] tty: imx serial: Implement support for reversing TX and RX polarity
Date: Mon, 10 Feb 2020 21:50:03 +0100 [thread overview]
Message-ID: <20200210205003.x7xduj3avwjhimjm@pengutronix.de> (raw)
In-Reply-To: <20200210192949.7338-3-ghilliard@kopismobile.com>
Hello George,
On Mon, Feb 10, 2020 at 01:29:49PM -0600, George Hilliard wrote:
> @@ -1390,6 +1392,8 @@ static int imx_uart_startup(struct uart_port *port)
> ucr4 = imx_uart_readl(sport, UCR4) & ~UCR4_OREN;
> if (!sport->dma_is_enabled)
> ucr4 |= UCR4_OREN;
> + if (sport->inverted_rx)
> + ucr4 |= UCR4_INVR;
You fail to clear this bit if .inverted_rx is false.
> imx_uart_writel(sport, ucr4, UCR4);
>
> ucr2 = imx_uart_readl(sport, UCR2) & ~UCR2_ATEN;
> @@ -1404,19 +1408,17 @@ static int imx_uart_startup(struct uart_port *port)
> ucr2 &= ~UCR2_RTSEN;
> imx_uart_writel(sport, ucr2, UCR2);
>
> + ucr3 = imx_uart_readl(sport, UCR3);
> + if (sport->inverted_tx)
> + ucr3 |= UCR3_INVT;
ditto.
Also I think setting this bit here is a bit late because UCR2_TXEN was
already set so changing UCR3_INVT probably results in a spike?!
> if (!imx_uart_is_imx1(sport)) {
> - u32 ucr3;
> -
> - ucr3 = imx_uart_readl(sport, UCR3);
> [...]
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2020-02-10 20:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 19:29 [PATCH v2 0/2] Implement support for inverted serial TX/RX on i.MX George Hilliard
2020-02-10 19:29 ` [PATCH v2 1/2] dt-bindings: serial: document fsl,inverted-tx and -rx options George Hilliard
2020-02-10 19:29 ` [PATCH v2 2/2] tty: imx serial: Implement support for reversing TX and RX polarity George Hilliard
2020-02-10 20:50 ` Uwe Kleine-König [this message]
2020-02-10 23:03 ` George Hilliard
2020-02-11 7:38 ` Uwe Kleine-König
2020-02-11 16:18 ` George Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210205003.x7xduj3avwjhimjm@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=ghilliard@kopismobile.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).