From: Daniel Thompson <daniel.thompson@linaro.org>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: dianders@chromium.org, linux-serial@vger.kernel.org,
linux@armlinux.org.uk, gregkh@linuxfoundation.org,
jslaby@suse.com, jason.wessel@windriver.com,
kgdb-bugreport@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: amba-pl011: Support earlycon_kgdboc
Date: Tue, 28 Apr 2020 14:54:56 +0100 [thread overview]
Message-ID: <20200428135456.2d7zxz2mdte5kclk@holly.lan> (raw)
In-Reply-To: <1587716031-28199-1-git-send-email-sumit.garg@linaro.org>
On Fri, Apr 24, 2020 at 01:43:51PM +0530, Sumit Garg wrote:
> Implement the read() function in the early console driver. With
> recently added earlycon_kgdboc feature, this allows you to use kgdb
> to debug fairly early into the system boot.
>
> We only bother implementing this if polling is enabled since kgdb can't
> be enabled without that.
>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
>
> Depends on kgdb patch series: https://lkml.org/lkml/2020/4/21/1179
>
> drivers/tty/serial/amba-pl011.c | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
> index 2296bb0..c010f63 100644
> --- a/drivers/tty/serial/amba-pl011.c
> +++ b/drivers/tty/serial/amba-pl011.c
> @@ -2435,6 +2435,37 @@ static void pl011_early_write(struct console *con, const char *s, unsigned n)
> uart_console_write(&dev->port, s, n, pl011_putc);
> }
>
> +#ifdef CONFIG_CONSOLE_POLL
> +static int pl011_getc(struct uart_port *port)
> +{
> + if (readl(port->membase + UART01x_FR) & UART01x_FR_RXFE)
> + return NO_POLL_CHAR;
> +
> + if (port->iotype == UPIO_MEM32)
> + return readl(port->membase + UART01x_DR);
> + else
> + return readb(port->membase + UART01x_DR);
> +}
> +
> +static int pl011_early_read(struct console *con, char *s, unsigned int n)
> +{
> + struct earlycon_device *dev = con->data;
> + int ch, num_read = 0;
> +
> + while (num_read < n) {
> + ch = pl011_getc(&dev->port);
> + if (ch == NO_POLL_CHAR)
> + break;
> +
> + s[num_read++] = ch;
> + }
> +
> + return num_read;
> +}
> +#else
> +#define pl011_early_read NULL
> +#endif
> +
> /*
> * On non-ACPI systems, earlycon is enabled by specifying
> * "earlycon=pl011,<address>" on the kernel command line.
> @@ -2454,6 +2485,7 @@ static int __init pl011_early_console_setup(struct earlycon_device *device,
> return -ENODEV;
>
> device->con->write = pl011_early_write;
> + device->con->read = pl011_early_read;
>
> return 0;
> }
> --
> 2.7.4
>
prev parent reply other threads:[~2020-04-28 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 8:13 [PATCH] serial: amba-pl011: Support earlycon_kgdboc Sumit Garg
2020-04-24 18:17 ` Doug Anderson
2020-04-28 13:54 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428135456.2d7zxz2mdte5kclk@holly.lan \
--to=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason.wessel@windriver.com \
--cc=jslaby@suse.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).