From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
"Matwey V. Kornilov" <matwey@sai.msu.ru>,
Giulio Benetti <giulio.benetti@micronovasrl.com>,
Heiko Stuebner <heiko@sntech.de>,
Christoph Muellner <christoph.muellner@theobroma-systems.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/4] serial: 8250: Avoid error message on reprobe
Date: Tue, 5 May 2020 19:01:01 +0300 [thread overview]
Message-ID: <20200505160101.GV185537@smile.fi.intel.com> (raw)
In-Reply-To: <b3fbbe8688d5e9d173168ae45295719ca4c9d35f.1588505407.git.lukas@wunner.de>
On Tue, May 05, 2020 at 04:42:01PM +0200, Lukas Wunner wrote:
> If the call to uart_add_one_port() in serial8250_register_8250_port()
> fails, a half-initialized entry in the serial_8250ports[] array is left
> behind.
>
> A subsequent reprobe of the same serial port causes that entry to be
> reused. Because uart->port.dev is set, uart_remove_one_port() is called
> for the half-initialized entry and bails out with an error message:
>
> bcm2835-aux-uart 3f215040.serial: Removing wrong port: (null) != (ptrval)
>
> The same happens on failure of mctrl_gpio_init() since commit
> 4a96895f74c9 ("tty/serial/8250: use mctrl_gpio helpers").
>
> Fix by zeroing the uart->port.dev pointer in the probe error path.
Fixes tag?
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> Cc: stable@vger.kernel.org # v2.6.10+
...
> ret = uart_add_one_port(&serial8250_reg,
> &uart->port);
> - if (ret == 0)
> + if (ret)
> + goto err;
> + else
Redundant.
> ret = uart->port.line;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-05 16:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 14:42 [PATCH 0/4] rs485 bus termination GPIO Lukas Wunner
2020-05-05 14:42 ` [PATCH 1/4] serial: 8250: Avoid error message on reprobe Lukas Wunner
2020-05-05 16:01 ` Andy Shevchenko [this message]
2020-05-06 6:06 ` Lukas Wunner
2020-05-06 10:01 ` Andy Shevchenko
2020-05-06 11:54 ` Lukas Wunner
2020-05-05 14:42 ` [PATCH 2/4] serial: Allow uart_get_rs485_mode() to return errno Lukas Wunner
2020-05-05 14:42 ` [PATCH 3/4] dt-bindings: serial: Add binding for rs485 bus termination GPIO Lukas Wunner
2020-05-05 14:42 ` [PATCH 4/4] serial: 8250: Support " Lukas Wunner
2020-05-05 16:10 ` Andy Shevchenko
2020-05-06 6:29 ` Lukas Wunner
2020-05-06 10:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505160101.GV185537@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=giulio.benetti@micronovasrl.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jslaby@suse.com \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=matwey@sai.msu.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).