From: Matthias Kaehlcke <mka@chromium.org>
To: Akash Asthana <akashast@codeaurora.org>
Cc: gregkh@linuxfoundation.org, agross@kernel.org,
bjorn.andersson@linaro.org, wsa@the-dreams.de,
broonie@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org,
linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, swboyd@chromium.org,
mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-serial@vger.kernel.org, dianders@chromium.org,
evgreen@chromium.org, georgi.djakov@linaro.org
Subject: Re: [PATCH V5 6/7] spi: spi-qcom-qspi: Add interconnect support
Date: Fri, 8 May 2020 11:53:10 -0700 [thread overview]
Message-ID: <20200508185310.GF4525@google.com> (raw)
In-Reply-To: <1588919619-21355-7-git-send-email-akashast@codeaurora.org>
On Fri, May 08, 2020 at 12:03:38PM +0530, Akash Asthana wrote:
> Get the interconnect paths for QSPI device and vote according to the
> current bus speed of the driver.
>
> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
> ---
> Changes in V2:
> - As per Bjorn's comment, introduced and using devm_of_icc_get API for getting
> path handle
> - As per Matthias comment, added error handling for icc_set_bw call
>
> Changes in V3:
> - No Change.
>
> Changes in V4:
> - As per Mark's comment move peak_bw guess as twice of avg_bw if
> nothing mentioned explicitly to ICC core.
>
> Changes in V5:
> - Add icc_enable/disable to power on/off call.
> - Save some non-zero avg/peak value to ICC core by calling geni_icc_set_bw
> from probe so that when resume/icc_enable is called NOC are running at
> some non-zero value.
>
> drivers/spi/spi-qcom-qspi.c | 59 ++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 58 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c
> index 3c4f83b..6e299f4 100644
> --- a/drivers/spi/spi-qcom-qspi.c
> +++ b/drivers/spi/spi-qcom-qspi.c
> @@ -2,6 +2,7 @@
> // Copyright (c) 2017-2018, The Linux foundation. All rights reserved.
>
> #include <linux/clk.h>
> +#include <linux/interconnect.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/module.h>
> @@ -139,7 +140,10 @@ struct qcom_qspi {
> struct device *dev;
> struct clk_bulk_data *clks;
> struct qspi_xfer xfer;
> - /* Lock to protect xfer and IRQ accessed registers */
> + struct icc_path *icc_path_cpu_to_qspi;
> + unsigned int avg_bw_cpu;
> + unsigned int peak_bw_cpu;
There is no point in having two fields, 'peak_bw_cpu' is always assigned
to 'avg_bw_cpu' and passed to icc_set_bw(). Just make it a single field
'icc_bw_cpu'.
> + /* Lock to protect data accessed by IRQs */
> spinlock_t lock;
> };
>
> @@ -241,6 +245,20 @@ static int qcom_qspi_transfer_one(struct spi_master *master,
> return ret;
> }
>
> + /*
> + * Set BW quota for CPU as driver supports FIFO mode only.
> + * We don't have explicit peak requirement so keep it equal to avg_bw.
> + */
> + ctrl->avg_bw_cpu = Bps_to_icc(speed_hz);
> + ctrl->peak_bw_cpu = ctrl->avg_bw_cpu;
> + ret = icc_set_bw(ctrl->icc_path_cpu_to_qspi, ctrl->avg_bw_cpu,
> + ctrl->peak_bw_cpu);
> + if (ret) {
> + dev_err(ctrl->dev, "%s: ICC BW voting failed for cpu\n",
> + __func__);
the logging in this patch is inconsistent. Here the error is not printed,
at all, in other cases it's "<error>, ret:-42" or "<error> ret:-42".
Please stick to a common format (unless there is no error). My
suggestion would be "<error>: -42", in my perception "ret:" just adds
noise.
> + return ret;
> + }
> +
> spin_lock_irqsave(&ctrl->lock, flags);
>
> /* We are half duplex, so either rx or tx will be set */
> @@ -458,6 +476,29 @@ static int qcom_qspi_probe(struct platform_device *pdev)
> if (ret)
> goto exit_probe_master_put;
>
> + ctrl->icc_path_cpu_to_qspi = devm_of_icc_get(dev, "qspi-config");
> + if (IS_ERR(ctrl->icc_path_cpu_to_qspi)) {
> + ret = PTR_ERR(ctrl->icc_path_cpu_to_qspi);
> + if (ret != -EPROBE_DEFER)
> + dev_err(dev, "Failed to get cpu path, ret:%d\n", ret);
> + goto exit_probe_master_put;
> + }
> + /* Set BW vote for register access */
> + ret = icc_set_bw(ctrl->icc_path_cpu_to_qspi, Bps_to_icc(1000),
> + Bps_to_icc(1000));
> + if (ret) {
> + dev_err(ctrl->dev, "%s: ICC BW voting failed for cpu ret:%d\n",
> + __func__, ret);
> + goto exit_probe_master_put;
> + }
> +
> + ret = icc_disable(ctrl->icc_path_cpu_to_qspi);
> + if (ret) {
> + dev_err(ctrl->dev, "%s: ICC disable failed for cpu ret:%d\n",
> + __func__, ret);
> + goto exit_probe_master_put;
> + }
> +
> ret = platform_get_irq(pdev, 0);
> if (ret < 0)
> goto exit_probe_master_put;
> @@ -511,9 +552,17 @@ static int __maybe_unused qcom_qspi_runtime_suspend(struct device *dev)
> {
> struct spi_master *master = dev_get_drvdata(dev);
> struct qcom_qspi *ctrl = spi_master_get_devdata(master);
> + int ret;
>
> clk_bulk_disable_unprepare(QSPI_NUM_CLKS, ctrl->clks);
>
> + ret = icc_disable(ctrl->icc_path_cpu_to_qspi);
> + if (ret) {
> + dev_err_ratelimited(ctrl->dev, "%s: ICC disable failed for cpu ret:%d\n",
> + __func__, ret);
> + return ret;
> + }
> +
> return 0;
> }
>
> @@ -521,6 +570,14 @@ static int __maybe_unused qcom_qspi_runtime_resume(struct device *dev)
> {
> struct spi_master *master = dev_get_drvdata(dev);
> struct qcom_qspi *ctrl = spi_master_get_devdata(master);
> + int ret;
> +
> + ret = icc_enable(ctrl->icc_path_cpu_to_qspi);
> + if (ret) {
> + dev_err_ratelimited(ctrl->dev, "%s: ICC enable failed for cpu ret:%d\n",
> + __func__, ret);
> + return ret;
> + }
>
> return clk_bulk_prepare_enable(QSPI_NUM_CLKS, ctrl->clks);
> }
next prev parent reply other threads:[~2020-05-08 18:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 6:33 [PATCH V5 0/7] Add interconnect support to QSPI and QUP drivers Akash Asthana
2020-05-08 6:33 ` [PATCH V5 1/7] soc: qcom: geni: Support for ICC voting Akash Asthana
2020-05-08 17:13 ` Matthias Kaehlcke
2020-05-12 14:02 ` Akash Asthana
2020-05-08 19:03 ` Matthias Kaehlcke
2020-05-12 14:26 ` Akash Asthana
2020-05-08 6:33 ` [PATCH V5 2/7] soc: qcom-geni-se: Add interconnect support to fix earlycon crash Akash Asthana
2020-05-08 17:59 ` Matthias Kaehlcke
2020-05-08 19:14 ` Matthias Kaehlcke
2020-05-14 7:03 ` Akash Asthana
2020-05-14 6:45 ` Akash Asthana
2020-05-09 12:11 ` Andy Shevchenko
2020-05-14 7:34 ` Akash Asthana
2020-05-08 6:33 ` [PATCH V5 3/7] i2c: i2c-qcom-geni: Add interconnect support Akash Asthana
2020-05-08 18:16 ` Matthias Kaehlcke
2020-05-15 10:03 ` Wolfram Sang
2020-05-08 6:33 ` [PATCH V5 4/7] spi: spi-geni-qcom: " Akash Asthana
2020-05-08 10:16 ` Mark Brown
2020-05-08 18:25 ` Matthias Kaehlcke
2020-05-14 7:37 ` Akash Asthana
2020-05-08 6:33 ` [PATCH V5 5/7] tty: serial: qcom_geni_serial: " Akash Asthana
2020-05-08 18:38 ` Matthias Kaehlcke
2020-05-08 6:33 ` [PATCH V5 6/7] spi: spi-qcom-qspi: " Akash Asthana
2020-05-08 10:16 ` Mark Brown
2020-05-08 18:53 ` Matthias Kaehlcke [this message]
2020-05-18 13:10 ` Akash Asthana
2020-05-08 6:33 ` [PATCH V5 7/7] arm64: dts: sc7180: Add interconnect for QUP and QSPI Akash Asthana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508185310.GF4525@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).