From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] serial: core: fix up sysrq regressions
Date: Wed, 10 Jun 2020 19:21:34 +0300 [thread overview]
Message-ID: <20200610162134.GL2428291@smile.fi.intel.com> (raw)
In-Reply-To: <20200610152232.16925-1-johan@kernel.org>
On Wed, Jun 10, 2020 at 05:22:29PM +0200, Johan Hovold wrote:
> This series fixes a few regressions introduced by the recent sysrq
> rework that went into 5.6.
>
> The fix for the unnecessary per-character overhead probably could have
> been marked for stable but I left that decision to the maintainers as it
> is a bit intrusive (although mostly shuffling code around).
I see a problem, thanks for pointing out!
The fix LGTM! FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Johan
>
> Changes in v2
> - inline uart_unlock_and_check_sysrq() along with the other helpers
> (restoring the interrupt state in a helper was never an issue)
>
>
> Johan Hovold (3):
> Revert "serial: core: Refactor uart_unlock_and_check_sysrq()"
> serial: core: fix sysrq overhead regression
> serial: core: drop redundant sysrq checks
>
> drivers/tty/serial/serial_core.c | 96 +----------------------------
> include/linux/serial_core.h | 102 +++++++++++++++++++++++++++++--
> 2 files changed, 100 insertions(+), 98 deletions(-)
>
> --
> 2.26.2
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-06-10 16:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 15:22 [PATCH v2 0/3] serial: core: fix up sysrq regressions Johan Hovold
2020-06-10 15:22 ` [PATCH v2 1/3] Revert "serial: core: Refactor uart_unlock_and_check_sysrq()" Johan Hovold
2020-06-10 15:22 ` [PATCH v2 2/3] serial: core: fix sysrq overhead regression Johan Hovold
2020-06-10 16:24 ` Dmitry Safonov
2020-06-12 15:29 ` Johan Hovold
2020-06-12 15:42 ` Dmitry Safonov
2020-06-12 15:52 ` Dmitry Safonov
2020-06-10 15:22 ` [PATCH v2 3/3] serial: core: drop redundant sysrq checks Johan Hovold
2020-06-12 15:55 ` Dmitry Safonov
2020-06-10 16:21 ` Andy Shevchenko [this message]
2020-06-12 15:31 ` [PATCH v2 0/3] serial: core: fix up sysrq regressions Johan Hovold
2020-06-27 14:16 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610162134.GL2428291@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=0x7f454c46@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).