From: Ye Bin <yebin10@huawei.com>
To: <chris.ruehl@gtsys.com.hk>, <gregkh@linuxfoundation.org>,
<linux-serial@vger.kernel.org>
Cc: Ye Bin <yebin10@huawei.com>
Subject: [PATCH v2] serial: imx: Delete duplicated argument to '|' in imx_uart_probe
Date: Thu, 3 Sep 2020 14:24:01 +0800 [thread overview]
Message-ID: <20200903062401.692442-1-yebin10@huawei.com> (raw)
When calculate "ucr1" UCR1_TRDYEN is duplicate.
Fixes: c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq")
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
drivers/tty/serial/imx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index ce8c472cf385..4e6ead1f650e 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -2389,8 +2389,7 @@ static int imx_uart_probe(struct platform_device *pdev)
/* Disable interrupts before requesting them */
ucr1 = imx_uart_readl(sport, UCR1);
- ucr1 &= ~(UCR1_ADEN | UCR1_TRDYEN | UCR1_IDEN | UCR1_RRDYEN |
- UCR1_TRDYEN | UCR1_RTSDEN);
+ ucr1 &= ~(UCR1_ADEN | UCR1_TRDYEN | UCR1_IDEN | UCR1_RRDYEN | UCR1_RTSDEN);
imx_uart_writel(sport, ucr1, UCR1);
if (!imx_uart_is_imx1(sport) && sport->dte_mode) {
--
2.25.4
next reply other threads:[~2020-09-03 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 6:24 Ye Bin [this message]
2020-09-03 7:35 ` [PATCH v2] serial: imx: Delete duplicated argument to '|' in imx_uart_probe Uwe Kleine-König
2020-09-04 15:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903062401.692442-1-yebin10@huawei.com \
--to=yebin10@huawei.com \
--cc=chris.ruehl@gtsys.com.hk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).