From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paras Sharma <parashar@codeaurora.org>
Cc: Jiri Slaby <jslaby@suse.com>,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, akashast@codeaurora.org
Subject: Re: [PATCH V4] serial: qcom_geni_serial: To correct QUP Version detection logic
Date: Wed, 16 Sep 2020 13:19:49 +0200 [thread overview]
Message-ID: <20200916111949.GA969520@kroah.com> (raw)
In-Reply-To: <1600067957-8216-1-git-send-email-parashar@codeaurora.org>
On Mon, Sep 14, 2020 at 12:49:17PM +0530, Paras Sharma wrote:
> The current implementation reduces the sampling rate by half
> if qup HW version is greater is than 2.5 by checking if the
2 space characters?
And what is "qup"?
What is "HW"?
> geni SE major version is greater than 2 and geni SE minor version
what is "geni"?
What is "SE"?
> is greater than 5.This implementation fails when the version is
> greater than or equal to 3.
>
> Hence, a new macro QUP_SE_VERSION_2_5 is defined having value
> for major number 2 and minor number 5 as 0x20050000.Hence,if
That's not a "macro", it is a simple #define.
And can you use a ' ' after a '.' please? That's all over this
changelog, including trailing whitespace for some reason :(
> ver is greater than this value,sampling rate is halved.
> This logic would work for any future qup version.
"will work"?
>
> Fixes: ce734600545f ("tty: serial: qcom_geni_serial: Update the oversampling rate")
> Signed-off-by: Paras Sharma <parashar@codeaurora.org>
> ---
> Changes in V4:
> Created a new macro QUP_SE_VERSION_2_5 for Qup se version 2.5
>
What changed from previous versions than v4?
thanks,
greg k-h
prev parent reply other threads:[~2020-09-16 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 7:19 [PATCH V4] serial: qcom_geni_serial: To correct QUP Version detection logic Paras Sharma
2020-09-15 12:39 ` Akash Asthana
2020-09-16 11:19 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916111949.GA969520@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akashast@codeaurora.org \
--cc=jslaby@suse.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=parashar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).