From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Jan Kundrát" <jan.kundrat@cesnet.cz>,
"Mark Brown" <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH] serial: max310x: rework RX interrupt handling
Date: Wed, 30 Sep 2020 16:50:37 +0200 [thread overview]
Message-ID: <20200930165037.77813365@windsurf.home> (raw)
In-Reply-To: <CAHp75VccK7hu51qCdRC4GaTO3XaSaYLD6TeuuqHLY9Tf1Tb67A@mail.gmail.com>
Hello,
On Wed, 30 Sep 2020 17:24:48 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On a Microchip SAMA5D3 platform that is receiving 20 bytes every 16ms
> > over one MAX310X UART, this patch has allowed to reduce the CPU
> > consumption of the interrupt handler thread from ~25% to 6-7%.
>
> Was it always like this?
As far as I can see, yes. I guess you were thinking about a Fixes: tag
perhaps? I don't think a Fixes: tag really applies here, as we're not
fixing a performance regression.
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > - /* Configure MODE2 register & Reset FIFOs*/
> > - val = MAX310X_MODE2_RXEMPTINV_BIT | MAX310X_MODE2_FIFORST_BIT;
> > - max310x_port_write(port, MAX310X_MODE2_REG, val);
> > + /* Reset FIFOs*/
>
> Add a space before the asterisk.
Indeed. Let me know if a v2 is needed, or if this small typo can be
fixed when applying.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-09-30 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 13:51 [PATCH] serial: max310x: rework RX interrupt handling Thomas Petazzoni
2020-09-30 14:24 ` Andy Shevchenko
2020-09-30 14:50 ` Thomas Petazzoni [this message]
2020-09-30 14:54 ` Andy Shevchenko
2020-10-02 12:40 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930165037.77813365@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jan.kundrat@cesnet.cz \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).