linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nuno Gonçalves" <nunojpg@gmail.com>
To: linux-serial@vger.kernel.org, yegorslists@googlemail.com
Cc: sr@denx.de, andriy.shevchenko@linux.intel.com,
	mika.westerberg@linux.intel.com, giulio.benetti@micronovasrl.com,
	gregkh@linuxfoundation.org
Subject: Re: Regression since 4a96895f74c9633b51427fd080ab70fa62b65bc4
Date: Sun, 29 Sep 2019 08:46:47 +0200	[thread overview]
Message-ID: <CAEXMXLSty8v1K_yaxoAnoMEny=XYn2ngUdCPi_0uTqy5NTViAQ@mail.gmail.com> (raw)
In-Reply-To: <CAEXMXLRBpQcSq3SrvL4LkG8_7S0CWJFGqRCnjywjbUEPZg9XxQ@mail.gmail.com>

I have since found that I am affected by two apparently different
regressions since 5.3.

4a96895f74c9633b51427fd080ab70fa62b65bc4 is only confirmed to affect
me on a omap8250 where the issue is that there are a few char errors
every few seconds. I can't confirm if chars are added, removed or
changed, for now I only can confirm my state machine looses tracking.

I will make a separate report from the problem identified on sunxi.

On Sat, Sep 28, 2019 at 7:59 AM Nuno Gonçalves <nunojpg@gmail.com> wrote:
>
> On 32 bit arm platforms (am335x and sunxi) I get unexpected bytes on
> serial ports after this commit.
>
> I use CTS (so: for input flow control).
>
> I've observed two different issues, one where I get just a few missed
> or added bytes about once a minute, and another where I get totally
> unexpected chars until I reopen the port.
>
> I will have a hard time to analyse and give a better description of
> how exactly the port is failing, so maybe you have a idea of what is
> the issue with this patch.
>
> I've reverted this on top of 5.3.1 and consistently got the issue fixed.
>
> Thanks,
> Nuno
>
> commit 4a96895f74c9633b51427fd080ab70fa62b65bc4
> Author: Yegor Yefremov <yegorslists@googlemail.com>
> Date:   Thu Jun 20 08:24:20 2019 +0200
>
>     tty/serial/8250: use mctrl_gpio helpers
>
>     This patch permits the usage for GPIOs to control
>     the CTS/RTS/DTR/DSR/DCD/RI signals.
>
>     Changed by Stefan:
>     Only call mctrl_gpio_init(), if the device has no ACPI companion device
>     to not break existing ACPI based systems. Also only use the mctrl_gpio_
>     functions when "gpios" is available.
>
>     Use MSR / MCR <-> TIOCM wrapper functions.
>
>     Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>     Signed-off-by: Stefan Roese <sr@denx.de>
>     Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>     Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>     Tested-by: Yegor Yefremov <yegorslists@googlemail.com>
>     Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
>     Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>     Cc: Giulio Benetti <giulio.benetti@micronovasrl.com>
>     Cc: Yegor Yefremov <yegorslists@googlemail.com>
>     Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

  reply	other threads:[~2019-09-29  6:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-28  5:59 Regression since 4a96895f74c9633b51427fd080ab70fa62b65bc4 Nuno Gonçalves
2019-09-29  6:46 ` Nuno Gonçalves [this message]
2019-10-01 20:02   ` Yegor Yefremov
2019-10-01 21:03     ` Nuno Gonçalves
2019-10-17  9:19       ` Nuno Gonçalves
2019-10-17 13:34         ` Yegor Yefremov
2019-10-28 11:09           ` Yegor Yefremov
2019-10-28 11:11             ` Nuno Gonçalves
2019-10-28 11:12               ` Yegor Yefremov
2019-10-28 11:14                 ` Nuno Gonçalves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEXMXLSty8v1K_yaxoAnoMEny=XYn2ngUdCPi_0uTqy5NTViAQ@mail.gmail.com' \
    --to=nunojpg@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=giulio.benetti@micronovasrl.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=sr@denx.de \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).