From: Mateusz Holenko <mholenko@antmicro.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Stafford Horne <shorne@gmail.com>,
Karol Gugala <kgugala@antmicro.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Paul E. McKenney" <paulmck@linux.ibm.com>,
Filip Kokosinski <fkokosinski@antmicro.com>,
Pawel Czarnecki <pczarnecki@internships.antmicro.com>,
Joel Stanley <joel@jms.id.au>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Maxime Ripard <mripard@kernel.org>,
Shawn Guo <shawnguo@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Sam Ravnborg <sam@ravnborg.org>, Icenowy Zheng <icenowy@aosc.io>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Gabriel L. Somlo" <gsomlo@gmail.com>
Subject: Re: [PATCH v11 5/5] drivers/tty/serial: add LiteUART driver
Date: Tue, 6 Oct 2020 09:11:43 +0200 [thread overview]
Message-ID: <CAPk366R-1EAbUJXLNpsvzLPHR66rOb1OWWbd_=gNYqheJYa7Qg@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdVzUJwV=E-AssEHHH1GQuXcHHBUGAJZ-+GwNyPFN_KL+A@mail.gmail.com>
Hi Geert,
On Fri, Sep 25, 2020 at 3:41 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Mateusz,
>
> On Wed, Sep 23, 2020 at 12:12 PM Mateusz Holenko <mholenko@antmicro.com> wrote:
> > From: Filip Kokosinski <fkokosinski@antmicro.com>
> >
> > This commit adds driver for the FPGA-based LiteUART serial controller
> > from LiteX SoC builder.
> >
> > The current implementation supports LiteUART configured
> > for 32 bit data width and 8 bit CSR bus width.
> >
> > It does not support IRQ.
> >
> > Signed-off-by: Filip Kokosinski <fkokosinski@antmicro.com>
> > Signed-off-by: Mateusz Holenko <mholenko@antmicro.com>
>
> Thanks for your patch!
Thanks for your review!
>
> > --- /dev/null
> > +++ b/drivers/tty/serial/liteuart.c
>
> > +static int liteuart_probe(struct platform_device *pdev)
> > +{
> > + struct device_node *np = pdev->dev.of_node;
> > + struct liteuart_port *uart;
> > + struct uart_port *port;
> > + struct xa_limit limit;
> > + int dev_id, ret;
> > +
> > + /* no device tree */
> > + if (!np)
> > + return -ENODEV;
> > +
> > + /* look for aliases; auto-enumerate for free index if not found */
> > + dev_id = of_alias_get_id(np, "serial");
> > + if (dev_id < 0)
> > + limit = XA_LIMIT(0, CONFIG_SERIAL_LITEUART_MAX_PORTS);
> > + else
> > + limit = XA_LIMIT(dev_id, dev_id);
> > +
> > + uart = kzalloc(sizeof(struct liteuart_port), GFP_KERNEL);
>
> Who frees this memory? Use devm_kzalloc()?
You are right - it leaks right now. We'll switch to devm_kzalloc().
> > + if (!uart)
> > + return -ENOMEM;
> > +
> > + ret = xa_alloc(&liteuart_array, &dev_id, uart, limit, GFP_KERNEL);
>
> Who frees this entry?
We'll add a call to xa_erase() when removing the driver.
> > + if (ret)
> > + return ret;
> > +
> > + port = &uart->port;
> > +
> > + /* get membase */
> > + port->membase = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> > + if (!port->membase)
> > + return -ENXIO;
> > +
> > + /* values not from device tree */
> > + port->dev = &pdev->dev;
> > + port->iotype = UPIO_MEM;
> > + port->flags = UPF_BOOT_AUTOCONF;
> > + port->ops = &liteuart_ops;
> > + port->regshift = 2;
> > + port->fifosize = 16;
> > + port->iobase = 1;
> > + port->type = PORT_UNKNOWN;
> > + port->line = dev_id;
> > + spin_lock_init(&port->lock);
> > +
> > + return uart_add_one_port(&liteuart_driver, &uart->port);
> > +}
>
> > +static int __init liteuart_init(void)
> > +{
> > + int res;
> > +
> > + res = uart_register_driver(&liteuart_driver);
> > + if (res)
> > + return res;
> > +
> > + res = platform_driver_register(&liteuart_platform_driver);
> > + if (res) {
> > + uart_unregister_driver(&liteuart_driver);
> > + return res;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static void __exit liteuart_exit(void)
> > +{
> > + platform_driver_unregister(&liteuart_platform_driver);
> > + uart_unregister_driver(&liteuart_driver);
> > +}
> > +
> > +module_init(liteuart_init);
> > +module_exit(liteuart_exit);
>
> Several drivers call uart_{,un}register_driver() from their .probe()
> resp. .remove() callbacks, so they can use module_platform_driver()
> instead of the above boilerplate. Greg, what's your stance on that?
I don't have much experience here and can't tell which version is the
preferred one.
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Best regards,
Mateusz
--
Mateusz Holenko
Antmicro Ltd | www.antmicro.com
Roosevelta 22, 60-829 Poznan, Poland
prev parent reply other threads:[~2020-10-06 7:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 10:08 [PATCH v11 0/5] LiteX SoC controller and LiteUART serial driver Mateusz Holenko
2020-09-23 10:08 ` [PATCH v11 1/5] dt-bindings: vendor: add vendor prefix for LiteX Mateusz Holenko
2020-09-23 10:08 ` [PATCH v11 2/5] dt-bindings: soc: document LiteX SoC Controller bindings Mateusz Holenko
2020-09-25 12:48 ` Geert Uytterhoeven
2020-10-06 6:30 ` Mateusz Holenko
2020-09-23 10:09 ` [PATCH v11 3/5] drivers/soc/litex: add LiteX SoC Controller driver Mateusz Holenko
2020-09-23 11:56 ` Jonathan Cameron
2020-10-06 6:34 ` Mateusz Holenko
2020-09-25 13:16 ` Geert Uytterhoeven
2020-09-25 15:06 ` Gabriel L. Somlo
2020-09-30 7:32 ` Geert Uytterhoeven
2020-10-06 10:07 ` Mateusz Holenko
2020-10-06 8:02 ` Mateusz Holenko
2020-10-06 8:38 ` Geert Uytterhoeven
2020-10-06 13:29 ` Mateusz Holenko
2020-09-23 10:09 ` [PATCH v11 4/5] dt-bindings: serial: document LiteUART bindings Mateusz Holenko
2020-09-25 13:16 ` Geert Uytterhoeven
2020-10-06 7:00 ` Mateusz Holenko
2020-10-06 7:07 ` Geert Uytterhoeven
2020-09-23 10:09 ` [PATCH v11 5/5] drivers/tty/serial: add LiteUART driver Mateusz Holenko
2020-09-25 13:40 ` Geert Uytterhoeven
2020-10-06 7:11 ` Mateusz Holenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPk366R-1EAbUJXLNpsvzLPHR66rOb1OWWbd_=gNYqheJYa7Qg@mail.gmail.com' \
--to=mholenko@antmicro.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=fkokosinski@antmicro.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=gsomlo@gmail.com \
--cc=heiko@sntech.de \
--cc=icenowy@aosc.io \
--cc=joel@jms.id.au \
--cc=jslaby@suse.com \
--cc=kgugala@antmicro.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=mripard@kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=pczarnecki@internships.antmicro.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).