From: Andy Duan <fugang.duan@nxp.com>
To: Michael Walle <michael@walle.cc>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Jiri Slaby <jslaby@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Leonard Crestez <leonard.crestez@nxp.com>
Subject: RE: [EXT] [PATCH v2 2/2] tty: serial: fsl_lpuart: fix return value checking
Date: Wed, 25 Mar 2020 10:07:14 +0000 [thread overview]
Message-ID: <VI1PR0402MB3600E689FB51FD5D6E2A2911FFCE0@VI1PR0402MB3600.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200325090658.25967-2-michael@walle.cc>
From: Michael Walle <michael@walle.cc> Sent: Wednesday, March 25, 2020 5:07 PM
> The return value of lpuart_dma_tx_request() is an negative errno on failure
> and zero on success.
>
> Fixes: 159381df1442f ("tty: serial: fsl_lpuart: fix DMA operation when using
> IOMMU")
> Reported-by: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> changes since v1:
> - none
>
> drivers/tty/serial/fsl_lpuart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index
> 131018979b77..5d41075964f2 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -1538,7 +1538,7 @@ static void lpuart_tx_dma_startup(struct
> lpuart_port *sport)
> goto err;
>
> ret = lpuart_dma_tx_request(&sport->port);
> - if (!ret)
> + if (ret)
> goto err;
>
> init_waitqueue_head(&sport->dma_wait);
> --
> 2.20.1
next prev parent reply other threads:[~2020-03-25 10:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 9:06 [PATCH v2 1/2] tty: serial: fsl_lpuart: move dma_request_chan() Michael Walle
2020-03-25 9:06 ` [PATCH v2 2/2] tty: serial: fsl_lpuart: fix return value checking Michael Walle
2020-03-25 10:07 ` Andy Duan [this message]
2020-03-25 10:03 ` [EXT] [PATCH v2 1/2] tty: serial: fsl_lpuart: move dma_request_chan() Andy Duan
2020-03-25 18:05 ` Leonard Crestez
2020-03-26 14:32 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0402MB3600E689FB51FD5D6E2A2911FFCE0@VI1PR0402MB3600.eurprd04.prod.outlook.com \
--to=fugang.duan@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michael@walle.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).