From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Krishna Yarlagadda <kyarlagadda@nvidia.com>,
linux-serial@vger.kernel.org, linux-tegra@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH V2] serial: tegra: Only print FIFO error message when an error occurs
Date: Fri, 9 Jul 2021 00:25:41 +0200 [thread overview]
Message-ID: <YOd7ZTJf0WoQ8oKo@qmqm.qmqm.pl> (raw)
In-Reply-To: <20210630125643.264264-1-jonathanh@nvidia.com>
On Wed, Jun 30, 2021 at 01:56:43PM +0100, Jon Hunter wrote:
> The Tegra serial driver always prints an error message when enabling the
> FIFO for devices that have support for checking the FIFO enable status.
> Fix this by displaying the error message, only when an error occurs.
>
> Finally, update the error message to make it clear that enabling the
> FIFO failed and display the error code.
[...]
> @@ -1045,9 +1045,11 @@ static int tegra_uart_hw_init(struct tegra_uart_port *tup)
>
> if (tup->cdata->fifo_mode_enable_status) {
> ret = tegra_uart_wait_fifo_mode_enabled(tup);
> - dev_err(tup->uport.dev, "FIFO mode not enabled\n");
> - if (ret < 0)
> + if (ret < 0) {
> + dev_err(tup->uport.dev,
> + "Failed to enable FIFO mode: %d\n", ret);
Could you change this to use %pe and ERR_PTR(ret)?
Best Regards
Michał Mirosław
next prev parent reply other threads:[~2021-07-08 22:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 12:56 [PATCH V2] serial: tegra: Only print FIFO error message when an error occurs Jon Hunter
2021-06-30 17:25 ` Thierry Reding
2021-07-08 22:25 ` Michał Mirosław [this message]
2021-07-09 8:34 ` Jon Hunter
2021-07-09 11:38 ` Jon Hunter
2021-07-09 17:55 ` Michał Mirosław
2021-07-09 21:38 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOd7ZTJf0WoQ8oKo@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).